Skip to content

fix(agent): make planner step limit configurable#3532

Merged
esengine merged 1 commit into
main-v2from
codex/planner-step-limits
Jun 8, 2026
Merged

fix(agent): make planner step limit configurable#3532
esengine merged 1 commit into
main-v2from
codex/planner-step-limits

Conversation

@SivanCola

@SivanCola SivanCola commented Jun 8, 2026 •
edited by esengine
Loading

Copy link
Copy Markdown
Collaborator

Fixes #3525

Summary

  • add agent.planner_max_steps with a default of 12 and 0 meaning no planner round limit
  • use the planner-specific limit and error label in two-model planning instead of reusing agent.max_steps
  • add desktop settings controls for executor/planner step limits under Models > Usage
  • update config rendering, example config, README/SPEC docs, and regression tests

Testing

  • go test ./internal/agent ./internal/boot ./internal/config ./internal/cli
  • cd desktop && go test . -run 'TestSettings|TestSetAgent|Test.*Settings|TestProviderViewFromEntry'\n- npm run check:css && npm run test:typecheck

Closes #3467

@SivanCola SivanCola requested a review from esengine as a code owner June 8, 2026 07:00
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Jun 8, 2026

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@github-actions github-actions Bot added desktop Wails desktop app (desktop/**) agent Core agent loop (internal/agent, internal/control) config Configuration & setup (internal/config) v2 Go rewrite (1.x) — main-v2 branch, active development labels Jun 8, 2026
This was referenced Jun 8, 2026
Closed
Closed
Open
Open
esengine
esengine approved these changes Jun 8, 2026
View reviewed changes

@esengine esengine left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

根因定位准确(planner 只读探索硬编码 6 轮、报错却误写成 agent.max_steps)。修法干净:删掉硬编码、引入 agent.planner_max_steps(默认 12,0=不限)、pause 报错动态填正确的 knob,执行器 max_steps 独立;中英文档 + 桌面 StepLimitControl + 测试都齐。解决最热的 #3467 和 #3525。

@esengine esengine merged commit 0d248f7 into main-v2 Jun 8, 2026
11 checks passed
@esengine esengine deleted the codex/planner-step-limits branch June 8, 2026 07:20
@gelutjari gelutjari mentioned this pull request Jun 9, 2026
Closed
This was referenced Jun 10, 2026
Closed
Closed
Closed
dorokuma pushed a commit to dorokuma/DeepSeek-Reasonix that referenced this pull request Jun 10, 2026
@SivanCola @dorokuma
fix(agent): make planner step limit configurable (esengine#3532)
23b0906
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@esengine esengine esengine approved these changes

Assignees

No one assigned

Labels

agent Core agent loop (internal/agent, internal/control) config Configuration & setup (internal/config) desktop Wails desktop app (desktop/**) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Milestone

No milestone

2 participants

@SivanCola @esengine