ci: typecheck the desktop frontend (tsc --noEmit)#3420
Merged
Conversation
The desktop CI job stubs frontend/dist for the Go build and never runs tsc, so frontend-only TypeScript errors pass CI and only break at `wails build` — e.g. #3410, where duplicate locale keys from a clean text-merge broke the dev build while every check stayed green. After the Go build/test, install the wails CLI, run `wails generate module` to produce the (gitignored) wailsjs bindings tsc needs, then `pnpm run typecheck`. Rides the desktop job to reuse its Go + webkit toolchain rather than standing up a separate Node-only job.
2287571 to
a2b4c6b
Compare
CVEngineer66
pushed a commit
to CVEngineer66/DeepSeek-Reasonix
that referenced
this pull request
Jun 7, 2026
A second merged conflict artefact from esengine#2752 (onboarding) and esengine#3129 (InlineDiff) left an unclosed block at line 7082. Same root cause as PR esengine#3418 but at a different offset. The check-css-syntax.mjs script (PR esengine#3420) now catches this, but upstream itself is affected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
frontendCI job that runstsc --noEmit(pnpm run typecheck) on the desktop frontend.Why
The
desktopjob stubsfrontend/distfor the Go build and never runs tsc, so frontend-only TypeScript errors pass CI and only break atwails build. This already bit us twice:history.filter*locale keys from a clean text-merge broke the dev build while every check stayed green (fixed in fix(desktop): drop duplicate history.filter* keys breaking wails build #3415).How
New job mirrors
release-desktop.yml: node 22 / pnpm 10,pnpm install --frozen-lockfile, thenpnpm run typecheck.This PR's own CI exercises the new job — a green
frontendcheck confirms both that the job works and that main-v2's frontend is currently clean.