fix(desktop): drop duplicate history.filter* keys breaking wails build#3415
Merged
Conversation
en.ts and zh.ts each carried two identical blocks of the ten history.filter* keys: an earlier history PR added them, then #3408 added the same set again. The two blocks merged cleanly as text (appended at different offsets) but produced duplicate object properties, so tsc and `wails build` failed with TS1117 (#3410). The desktop CI job stubs the embedded frontend and never runs tsc, so the duplicates passed every check. Removed the redundant second block in each file (identical values; kept the first). Verified tsc --noEmit is clean after the fix. Fixes #3410
This was referenced Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #3410 —
wails buildfails on main-v2 withTS1117: An object literal cannot have multiple properties with the same nameinsrc/locales/en.ts. The desktop dev build is broken.Root cause
en.tsandzh.tseach carried two identical blocks of the tenhistory.filter*keys — an earlier history PR added them, then #3408 added the same set again. The blocks merged cleanly as text (appended at different offsets) but duplicate object properties are a TS error. ThedesktopCI job stubs the embedded frontend and never runs tsc, so the duplicates passed every check.Fix
Removed the redundant second block in each file (identical values; kept the first). Verified
tsc --noEmitis clean afterward.Note
This class of breakage (frontend-only TS errors slipping past CI) will recur until the
desktopCI job runstscon the frontend — worth a follow-up.