fix: load skills from symlinked directories (#2104)#2137
Merged
Conversation
SkillStore.readEntry() used entry.isDirectory() to detect skill directories, but Node.js Dirent.isDirectory() returns false for symlinks. This caused symlinked skill directories to be silently skipped with no error or warning. Added isSymbolicLink() check with statSync fallback to resolve symlinks and verify the target is a directory. Broken symlinks are safely skipped without throwing. Closes esengine#2104
1ecac42 to
179adce
Compare
This was referenced May 28, 2026
This was referenced May 29, 2026
esengine
added a commit
that referenced
this pull request
May 29, 2026
…dmin) (#2239) The two symlinked-skill tests added in #2137 — "loads skills from symlinked directories (#2104)" and "skips broken symlinks gracefully" — call symlinkSync with no Windows guard, so `npm run verify` fails with EPERM for contributors on Windows that lack Developer Mode / admin. CI's Windows runner has the privilege so it slipped through. Add `.skipIf(process.platform === "win32")`, matching the #2124 symlink tests already in this file. Co-authored-by: yhh <yhh@yhhdeMac-mini.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SkillStore.readEntry() uses entry.isDirectory() to detect skill directories, but Node.js Dirent.isDirectory() returns false for symlinks. This causes symlinked skill directories to be silently skipped.
Fix
Added isSymbolicLink() check with statSync fallback:
Closes #2104