fix(test): skip #2137 symlink skill tests on Windows (EPERM)#2239
Merged
Conversation
…dmin) The two symlinked-skill tests added in #2137 — "loads skills from symlinked directories (#2104)" and "skips broken symlinks gracefully" — call symlinkSync with no Windows guard, so `npm run verify` fails with EPERM for contributors on Windows that lack Developer Mode / admin. CI's Windows runner has the privilege so it slipped through. Add `.skipIf(process.platform === "win32")`, matching the #2124 symlink tests already in this file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A Windows contributor reported
npm run verifyfailing intests/skills.test.ts:The two symlinked-skill tests added in #2137 call
symlinkSyncwith no Windows guard. On Windows without Developer Mode / admin,symlinkSyncthrowsEPERM, so localverifyfails. CI's Windows runner has the privilege, so it wasn't caught there — but it breaks the local dev loop for Windows contributors.Fix
Add
.skipIf(process.platform === "win32")to both tests — matching the#2124symlink tests already in the same file (which guard the identical EPERM case).Verification
npx vitest run tests/skills.test.ts→ 56 passed (on macOS the tests still run; on Windows the 2 now skip instead of EPERM-failing)npm run verifypassed