Skip to content

[3.4] register --rpc.logs.maxresults in DefaultFlags so it takes effect via CLI#21389

Merged
AskAlexSharov merged 1 commit into
release/3.4from
lupin/fix_rpc_logs_maxresults_34
May 24, 2026
Merged

[3.4] register --rpc.logs.maxresults in DefaultFlags so it takes effect via CLI#21389
AskAlexSharov merged 1 commit into
release/3.4from
lupin/fix_rpc_logs_maxresults_34

Conversation

@lupin012

@lupin012 lupin012 commented May 24, 2026

Copy link
Copy Markdown
Contributor

closes #21372

@lupin012 lupin012 marked this pull request as ready for review May 24, 2026 17:37
@AskAlexSharov AskAlexSharov merged commit 7acfaad into release/3.4 May 24, 2026
32 of 34 checks passed
@AskAlexSharov AskAlexSharov deleted the lupin/fix_rpc_logs_maxresults_34 branch May 24, 2026 23:31
pull Bot pushed a commit to Dustin4444/erigon that referenced this pull request May 27, 2026
…effect via CLI (erigontech#21426)

## Summary

Forward-port of erigontech#21389 to `main`.

`RpcGetLogsMaxResults` was defined in `cmd/utils/flags.go` and consumed
in `node/cli/flags.go` (`ApplyFlagsForHttpCfg` populates
`GetLogsMaxResults`), but it was never added to the `DefaultFlags` slice
in `node/cli/default_flags.go`. As a result the `erigon` binary does not
register the flag and rejects it at startup:

```
Error: flag provided but not defined: -rpc.logs.maxresults
Run 'erigon --help' for usage.
```

Same bug that erigontech#21372 reported against `release/3.4`; the fix landed
there as erigontech#21389. `main` was missed.

One-line addition, placing the entry next to the already-registered
`--rpc.blockrange.limit`:

```diff
 &utils.RpcBlockRangeLimit,
+&utils.RpcGetLogsMaxResults,
 &utils.RpcBatchLimit,
```

## Test plan

- [x] `make lint` clean
- [x] `go build ./node/cli/...` clean
- [ ] CI passes
- [ ] After merge: confirm `erigon --rpc.logs.maxresults=10000 ...`
starts (no "flag provided but not defined")

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
yperbasis added a commit that referenced this pull request Jun 1, 2026
Adds the **v3.4.3** section to `ChangeLog.md`, covering the user-facing
changes merged to `release/3.4` since v3.4.2, and sets the v3.4.2 header
to its release date (2026-05-22).

**Bugfixes**
- #21538 — second fix for the post-reorg `gas used mismatch` /
state-leak still hitting v3.4.2 users
- #21507 — `debug_getModifiedAccountsByHash` / `ByNumber` now match Geth
semantics
- #21389 — `--rpc.logs.maxresults` (documented in 3.4.0) now takes
effect via the CLI

**Improvements**
- #21502 — fail-fast on oversized `engine_newPayload` backward download
(less per-slot log spam / wasted fetches)

Docs-only / internal PRs (#21451, #21408) are intentionally omitted.

Version bump tracked separately in #21547.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants