Skip to content

bug: --rpc.logs.maxresults flag not recognized by erigon binary in v3.4.1 #21372

@darkhorse-spb

Description

@darkhorse-spb

Description

--rpc.logs.maxresults is defined in cmd/utils/flags.go as RpcGetLogsMaxResults and is correctly consumed in node/cli/flags.go inside ApplyFlagsForHttpCfg (GetLogsMaxResults: ctx.Int(utils.RpcGetLogsMaxResults.Name)), but it was never added to the DefaultFlags slice in node/cli/default_flags.go. As a result the erigon binary does not register the flag and rejects it at startup:

Error: flag provided but not defined: -rpc.logs.maxresults
Run 'erigon --help' for usage.

The flag was introduced via cherry-pick PR #20784 into release/3.4, but the DefaultFlags registration was not included in that cherry-pick, making it unreachable from the integrated node binary despite being fully wired up internally.

Fix

One line addition to node/cli/default_flags.go, placing it next to the already-registered --rpc.blockrange.limit:

--- a/node/cli/default_flags.go
+++ b/node/cli/default_flags.go

Metadata

Metadata

Assignees

Labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions