[r3.4] [1/3] cmd: improve commitment snapshot removal output (cherry-pick #20202)#21116
Merged
Merged
Conversation
## Summary Improves output formatting for the commitment snapshot removal command: - **Path once**: prints snapshot directory path once at top, then filenames only - **Unwindable status**: replaces `found state key with kvi` → `Unwindable` and `found state key using bt` → `Not Unwindable (*)` - **Newline before removal list** for readability - **File sizes**: shows per-file size and total using `common.ByteCount` ## Before ``` found state key with kvi /path/to/snapshots/domain/v2.0-commitment.112-128.kv found state key with kvi /path/to/snapshots/domain/v2.0-commitment.16-32.kv REMOVE /path/to/snapshots/domain/v2.0-commitment.0-16.kv ... ``` ## After ``` Snapshot dir: /path/to/snapshots/domain/ v2.0-commitment.112-128.kv Unwindable v2.0-commitment.16-32.kv Unwindable REMOVE v2.0-commitment.0-16.kv (1.2 GiB) REMOVE v2.0-commitment.112-128.kv (1.1 GiB) Total: 9.4 GiB ``` Co-authored-by: shuo <shuo@erigon.dev> Co-authored-by: shuo <shuo@erigon.dev> (cherry picked from commit c286488)
This was referenced May 11, 2026
AskAlexSharov
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #20202 to release/3.4.