Skip to content

seg rm-state: improve interactive menu display#20525

Merged
AskAlexSharov merged 1 commit into
mainfrom
fix/seg-rm-state-menu-display
Apr 13, 2026
Merged

seg rm-state: improve interactive menu display#20525
AskAlexSharov merged 1 commit into
mainfrom
fix/seg-rm-state-menu-display

Conversation

@awskii

@awskii awskii commented Apr 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

  • Show KEEP/REMOVE markers and file sizes on commitment files before prompting (was shown after)
  • Print Datadir: and Step range: header for context
  • Pre-compute and display total file count and estimated deletion size in prompt (remove 38 files (~15.2GB)?)
  • Drop misleading Total: line that only summed commitment files

Before

Snapshot dir: /erigon-data/hoodi-tmp/snapshots/domain

  v2.0-commitment.0-32.kv  Unwindable
  v2.0-commitment.32-48.kv  Unwindable
  v2.0-commitment.48-56.kv  Unwindable
  v2.0-commitment.56-60.kv  Unwindable

remove latest snapshot files (stepFrom>=56) and files ending at stepTo=60?
1) RemoveFile
4) Exit
 (pick number): 4

After

Datadir: /erigon-data/hoodi-tmp
Step range: latest (stepFrom>=56)

  KEEP   v2.0-commitment.0-32.kv  (11.8GB)  Unwindable
  KEEP   v2.0-commitment.32-48.kv  (8.1GB)  Unwindable
  KEEP   v2.0-commitment.48-56.kv  (4.2GB)  Unwindable
  REMOVE v2.0-commitment.56-60.kv  (3.0GB)  Unwindable


remove 44 files (~9.7GB)?
1) RemoveFile
4) Exit
 (pick number):

@awskii awskii marked this pull request as ready for review April 13, 2026 12:03
@AskAlexSharov AskAlexSharov enabled auto-merge April 13, 2026 12:20
@AskAlexSharov AskAlexSharov added this pull request to the merge queue Apr 13, 2026
Merged via the queue into main with commit ef56c9b Apr 13, 2026
40 of 65 checks passed
@AskAlexSharov AskAlexSharov deleted the fix/seg-rm-state-menu-display branch April 13, 2026 14:15
This was referenced May 11, 2026
Merged
Merged
awskii added a commit that referenced this pull request May 11, 2026
@awskii
[r3.4] [2/3] seg rm-state: improve interactive menu display (cherry-p…
bf2e03e 
…ick #20525) (#21117)

Cherry-pick of #20525 to release/3.4.

Stacked on #21116 (cherry-pick of #20202). Merge order: 1/3 first, then
this. Change base to `release/3.4` after 1/3 lands.
awskii added a commit that referenced this pull request May 11, 2026
@awskii @AskAlexSharov
[r3.4] [3/3] cmd/utils: add --only-history flag to rm-state command (…
dd00617 
…cherry-pick #20899) (#21118)

Cherry-pick of #20899 to release/3.4.

Stacked on #21117 (cherry-pick of #20525). Merge order: 1/3 (#21116) →
2/3 (#21117) → this. Change base to `release/3.4` after 2/3 lands.

---------

Co-authored-by: Alex Sharov <AskAlexSharov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AskAlexSharov AskAlexSharov AskAlexSharov approved these changes

@Giulio2002 Giulio2002 Awaiting requested review from Giulio2002

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@awskii @AskAlexSharov