[r3.4] db/state: 4x default step, transparent execution log, no key referencing#20930
Merged
Conversation
| acRo.Close() | ||
|
|
||
| if !squeeze && !statecfg.Schema.CommitmentDomain.ReplaceKeysInValues { | ||
| if !squeeze { |
Member
There was a problem hiding this comment.
- statecfg.Schema.CommitmentDomain.ReplaceKeysInValues -- maybe keep this check
- change
squeezeflag default value = false
Member
Author
There was a problem hiding this comment.
statecfg.Schema.CommitmentDomain.ReplaceKeysInValues
keeping this makes regeneration process depending on current schema, i wanted to decouple this.
2 false yes, let it be like that. they are fine regardless erigon compiled with enabled refs or not, while referenced snapshot requires only compatible erigon version
AskAlexSharov
approved these changes
May 8, 2026
AskAlexSharov
added a commit
that referenced
this pull request
May 8, 2026
…no key referencing" (#21057) Reverts #20930 ``` go run ./cmd/erigon --datadir ~/data/chiado35_minimal/ --chain=chiado --prune.mode=minimal panic: runtime error: slice bounds out of range [20:3] goroutine 126 [running]: github.com/erigontech/erigon/execution/commitment.(*cell).hashStorageKey(...) /home/alex/projects/erigon/execution/commitment/hex_patricia_hashed.go:283 github.com/erigontech/erigon/execution/commitment.(*cell).deriveHashedKeys(0x4251ff67980, 0x44, {0x381ac40, 0x42506b53080}, 0x14, {0x4252003a6a8, 0x20, 0x20}) /home/alex/projects/erigon/execution/commitment/hex_patricia_hashed.go:481 +0x336 github.com/erigontech/erigon/execution/commitment.(*HexPatriciaHashed).unfoldBranchNode(0x4251ff56000, 0x9, 0x44, 0x0) /home/alex/projects/erigon/execution/commitment/hex_patricia_hashed.go:1827 +0x629 ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks 3 commits from
awskii/inc-shard-def-sizeontorelease/3.4:eae5788ad24x bigger default step (db/state/statecfg/state_schema.go)90f79e1dc3disable key referencing (db/state/domain_committed.go)12229c3f73more transparent execution (db/state/squeeze.go)A 4th commit (
56b2c9b3d8 wire step flag) is intentionally skipped — it depends onErigondbDomainStepsInFrozenFileFlag/LogErigondbDomainStepsInFrozenFileOverride/ aggregator builder methodErigondbDomainStepsInFrozenFile(), none of which exist onrelease/3.4. Wiring it would require backporting that whole API surface, which is out of scope here.go build ./db/state/... ./execution/commitment/... ./cmd/erigon/...passes locally.thats to be able to rebuild and run v3.4.0 without references.