performance: cherry-pick inc-shard-def-size updates#21033
Merged
Conversation
(cherry picked from commit 9ba41ee)
(cherry picked from commit 856b696)
(cherry picked from commit 831742f)
…ment rebuild and CommitmentRoot Replace LimitedHistoryStateReader (which fell back to GetLatest on miss and silently leaked post-limit values) with a strict files-only reader for the two callers that need a fixed boundary snapshot: - RebuildCommitmentFiles uses FilesOnlyStateReader(rwTx, lastTxnumInShard-1) so commitment.kv is rebuilt only from the matching accounts/storage/code .kv files at the shard boundary. - CheckCommitmentRoot's checkCommitmentRootViaSd uses FilesOnlyStateReader at maxTxNum, and checkCommitmentRootViaRecompute switches from an account-domain-only touchHistoricalKeys to sd.TouchChangedKeysFromHistory (accounts + storage; code is covered transitively via account.codeHash). getLatestFromFiles walkback is also fixed: the previous bound skipped files ending before maxTxNum, which broke the walkback semantics and made files-only reads return nil for any key whose latest write lives in an older .kv. Now only files starting strictly after maxTxNum are skipped.
…flag for seg retire
AskAlexSharov
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #20930, #21025, and #21026 onto performance.