warmuper: blocking and more (#20819)#20877
Merged
Merged
Conversation
in near past i did change warmupers logic to `non-blocking`. but seems it was mistake for non-chain-tip case. On bloatnet non-tip: i see 5x improvements in commitment speed - if make warmuper's channel `blocking`. Reason: there is so much cold keys that 20% of them go dropped. And it slow-down overall system throughput. Also increasing amount of warmupers more than `runtime.NumCPU()` helps +2x because it's oke to have `io-threads > cpu_amount` Current bloatnet speed (100 blocks batches): `gas/s=289.38M`, trie calc `keys/s=14.24k` ``` [INFO] [04-26|11:34:37.582] [4/6 Execution][agg] computing trie progress=2.27M/2.40M keys/s=14.24k akeys=349 skeys=2.27M rdb=4.37M rda=349 rds=3.11M wrb=5.25M cb=8.72M ca=209 cs=832.77k mb=18.57k ma=140 ms=2.28M fld=0 pdur=0s fdur=0s ufdur=0s alloc=21.7GB sys=30.2GB [INFO] [04-26|11:34:46.903] [4/6 Execution] serial done in=3m4.129222864s buf=5.6GB/2.9GB blk=24506399 blks=100 blk/s=0.54 txs=6.80k tx/s=36 gas/s=289.38M stepsInDB=0.72 step=7496.7 alloc=22.2GB sys=30.2GB isForkValidation=false isApplyingBlocks=true ```
wmitsuda
approved these changes
Apr 28, 2026
yperbasis
added a commit
that referenced
this pull request
Apr 28, 2026
lupin012
pushed a commit
that referenced
this pull request
May 2, 2026
Cherry-pick of #20819 to main. ## Conflicts resolved `execution/commitment/commitmentdb/commitment_context.go`: main has additional `ConcurrentPatriciaHashed` branching and a different warmup-config init layout. Kept main's structure; applied the two PR changes in-place — added the keys/s logging block and switched `NumWorkers` from `16` to `dbg.TipTrieWarmupers`. Added `encoding/hex` import for the new log line. Co-authored-by: Alex Sharov <AskAlexSharov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #20819 to main.
Conflicts resolved
execution/commitment/commitmentdb/commitment_context.go: main has additionalConcurrentPatriciaHashedbranching and a different warmup-config init layout. Kept main's structure; applied the two PR changes in-place — added the keys/s logging block and switchedNumWorkersfrom16todbg.TipTrieWarmupers. Addedencoding/heximport for the new log line.