warmuper: blocking and more #20819
Merged
Merged
Conversation
awskii
approved these changes
Apr 26, 2026
lemenkov
pushed a commit
to fedora-ethereum/erigon
that referenced
this pull request
Apr 28, 2026
Cherry-pick of erigontech#20819 to main. ## Conflicts resolved `execution/commitment/commitmentdb/commitment_context.go`: main has additional `ConcurrentPatriciaHashed` branching and a different warmup-config init layout. Kept main's structure; applied the two PR changes in-place — added the keys/s logging block and switched `NumWorkers` from `16` to `dbg.TipTrieWarmupers`. Added `encoding/hex` import for the new log line. Co-authored-by: Alex Sharov <AskAlexSharov@gmail.com>
lupin012
pushed a commit
that referenced
this pull request
May 2, 2026
Cherry-pick of #20819 to main. ## Conflicts resolved `execution/commitment/commitmentdb/commitment_context.go`: main has additional `ConcurrentPatriciaHashed` branching and a different warmup-config init layout. Kept main's structure; applied the two PR changes in-place — added the keys/s logging block and switched `NumWorkers` from `16` to `dbg.TipTrieWarmupers`. Added `encoding/hex` import for the new log line. Co-authored-by: Alex Sharov <AskAlexSharov@gmail.com>
AskAlexSharov
added a commit
that referenced
this pull request
May 7, 2026
Cherry-pick of #20819 to release/3.4. ## r3.4-specific adaptations - `commitment_context.go`: kept release/3.4's commented-out `[commitment] processed` log block; the upstream change to that log line (adding `keys/s`) was not meaningful since the log is disabled in 3.4. The functional change (`NumWorkers: 16` → `dbg.TipTrieWarmupers`) was applied cleanly. Co-authored-by: Alex Sharov <AskAlexSharov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in near past i did change warmupers logic to
non-blocking. but seems it was mistake for non-chain-tip case.On bloatnet non-tip: i see 5x improvements in commitment speed - if make warmuper's channel
blocking.Reason: there is so much cold keys that 20% of them go dropped. And it slow-down overall system throughput.
Also increasing amount of warmupers more than
runtime.NumCPU()helps +2x because it's oke to haveio-threads > cpu_amountCurrent bloatnet speed (100 blocks batches):
gas/s=289.38M, trie calckeys/s=14.24k