bloatnet: disable CheckCommitmentKvDeref #20813
Merged
Merged
Conversation
AskAlexSharov
commented
Apr 25, 2026
Collaborator
- because it can't finish
Contributor
There was a problem hiding this comment.
LGTM with the warning added. This is now at least explicit operational behavior rather than a silent skip: CommitmentKvDeref is intentionally disabled on bloatnet, and the user is told so with a pointer to the tracking issue. I still consider the sample-ratio reductions reasonable as a pragmatic performance tradeoff. Minor cleanup later: the unreachable CheckCommitmentKvDeref call after return could be removed, but it does not block approval.
wmitsuda
added a commit
that referenced
this pull request
Apr 27, 2026
… (#20838) Cherry-picks the integrity-area chain from `main` onto `performance`, in order: 1. #20435 — `integrity: restore StateProgress check` 2. #20680 — `integrity, stagedsync: cap state collation at block snapshots progress` 3. #20714 — `add time budget for integrity checks` 4. #20835 — `cmd/utils/app: skip commitment history integrity checks when disabled` #20714 is the structural refactor of `doIntegrity` (`errgroup.Go(switch{...})` → `runCheck := func{}` + budget loop). Conflicted with performance-only Bloatnet customizations on the same function (#20806, #20810, #20813); resolved by adopting #20714's shape and re-applying the Bloatnet handling for `CommitmentKvDeref`, `CommitmentHistVal`, and `StateRootVerifyByHistory`. `failFast` arg on `CheckCommitmentHistAtBlkRange` preserved (matches performance's signature). Submodule pointer for `execution/tests/execution-spec-tests` left unchanged. `make erigon` + `make lint` clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.