pagedWriter and compressor to use same COMPRESS_WORKERS variable and configuration field in agg#20281
Merged
Merged
Conversation
Giulio2002
approved these changes
Apr 2, 2026
Giulio2002
left a comment
Contributor
There was a problem hiding this comment.
LGTM — straightforward API consolidation: merges NewPagedWriter/NewPagedWriterWithWorkers into a single constructor with explicit workers param. All callers updated mechanically.
AskAlexSharov
added a commit
that referenced
this pull request
Apr 6, 2026
…d configuration field in `agg` (#20281)
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 6, 2026
Cherry-pick from release/3.4 to main. Original PRs: - #20335 — paged writer: lost amount of workers - #20281 — pagedWriter and compressor to use same COMPRESS_WORKERS variable - #20262 — stageloop, execmodule: add ERIGON_IN_MEM_HISTORY env flag - #20114 — crypto: zero-alloc, syncpool-free method to hash []byte type - #20194 — execution/state: revert CodeSizePath in codeChange journal entry 20 candidates checked total; 15 were already effectively on main. --------- Co-authored-by: moskud <sudeepdino008@gmail.com> Co-authored-by: awskii <awskii@users.noreply.github.com> Co-authored-by: Giulio rebuffo <giulio.rebuffo@gmail.com> Co-authored-by: lystopad <oleksandr.lystopad@erigon.tech> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FYI:
erigon seg retirewill use more cores forcommitment.vmerge