crypto: zero-alloc, syncpool-free method to hash []byte type#20114
Merged
Conversation
awskii
reviewed
Mar 26, 2026
| } | ||
| if len(code) > 0 { | ||
| copy(u.CodeHash[:], crypto.Keccak256(code)) | ||
| u.CodeHash = crypto.HashData(code) |
Member
There was a problem hiding this comment.
also can be used for some cells during fold instead of hph.keccak
awskii
approved these changes
Mar 26, 2026
AskAlexSharov
added a commit
that referenced
this pull request
Apr 6, 2026
problem: `sha.Read(h[:])` escaping to heap
- in RLP `func rlpHash` used new `sha.Sum256()` method - to prevent
heap-escaping caused by `sha.Read(h[:])` intereface-method:
```
if h, ok := sha.(*keccak.Hasher); ok {
return h.Sum256()
}
```
- in `crypto.HashData()`: used new `keccak.Sum256()` method - which
doesn't use `sync.Pool` and doesn't alloc (`-20ns`)
```
┌─────────────────────────────────┬───────┬──────┬───────────┐
│ Branch │ ns/op │ B/op │ allocs/op │
├─────────────────────────────────┼───────┼──────┼───────────┤
│ release/3.4 (pool + Read(h[:])) │ 272 │ 32 │ 1 │
├─────────────────────────────────┼───────┼──────┼───────────┤
│ current (keccak.Sum256 direct) │ 240 │ 0 │ 0 │
└─────────────────────────────────┴───────┴──────┴───────────┘
```
---------
Co-authored-by: awskii <awskii@users.noreply.github.com>
Co-authored-by: Giulio rebuffo <giulio.rebuffo@gmail.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 6, 2026
Cherry-pick from release/3.4 to main. Original PRs: - #20335 — paged writer: lost amount of workers - #20281 — pagedWriter and compressor to use same COMPRESS_WORKERS variable - #20262 — stageloop, execmodule: add ERIGON_IN_MEM_HISTORY env flag - #20114 — crypto: zero-alloc, syncpool-free method to hash []byte type - #20194 — execution/state: revert CodeSizePath in codeChange journal entry 20 candidates checked total; 15 were already effectively on main. --------- Co-authored-by: moskud <sudeepdino008@gmail.com> Co-authored-by: awskii <awskii@users.noreply.github.com> Co-authored-by: Giulio rebuffo <giulio.rebuffo@gmail.com> Co-authored-by: lystopad <oleksandr.lystopad@erigon.tech> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
problem:
sha.Read(h[:])escaping to heapfunc rlpHashused newsha.Sum256()method - to prevent heap-escaping caused bysha.Read(h[:])intereface-method:crypto.HashData(): used newkeccak.Sum256()method - which doesn't usesync.Pooland doesn't alloc (-20ns)