Fix hive tests 0302#18986
Merged
Merged
Conversation
AskAlexSharov
approved these changes
Feb 6, 2026
mattevans
added a commit
to ethpandaops/erigone-legacy
that referenced
this pull request
Feb 6, 2026
* upstream/main: (91 commits) perf(cl/block_collector): optimize encodeBlock buffer allocation (erigontech#18980) db/kv: fix code cache hash key computation (erigontech#18965) Fix hive tests 0302 (erigontech#18986) perf(execution/types): optimize EIP-7685 request encoding (erigontech#18985) refactor: replace interface{} with any for clarity and modernization (erigontech#18978) refactor: replace interface{} with any for clarity and modernization (erigontech#18977) Rework Dockerhub API call authorization mechanism. (erigontech#18989) claude: add erigon-network-ports skill (erigontech#18992) PersistentBlockCollector: assert on inserting gap (erigontech#18979) qa-tests: add Geth test to the RPC Historic Performance Tests (erigontech#18895) a bit less debug logs (erigontech#18974) ProcessFrozenBlocks: to support `isDomainAheadOfBlocks` (which we have in `fcu`) (erigontech#18981) qa-tests: fix summary in RPC Performance Tests Latest (erigontech#18984) handle edge case for genesis block in SeekCommitment (erigontech#18960) db/preverified: remove redundant assertSorted in Get (erigontech#18967) txnprovider/shutter: fix identity preimage DecodeSSZ error length (erigontech#18938) perf(cl/sentinel): use stack allocation for light_client response prefix (erigontech#18961) Add debug.SetupSimple, and improve torrent client status info log (erigontech#18953) Refactor worker count calculation to remove redundant bounds check (erigontech#18415) fix: remove duplicate TxPoolBlobPriceBumpFlag check in setTxPool (erigontech#18472) ...
Giulio2002
pushed a commit
that referenced
this pull request
Feb 6, 2026
This PR contains 2 changes + a series of printer adjustments which where useful in debugging, either to provide additional information or to remove what now seems like excess info or prints. The 2 functional changes are as follows: Regression fix: [only start header change for empty changeset](85f2d75) is a change to a regression created by removing a check which only added an additional start event for the genesis block. The original change was to fix another issue encountered in running unit tests - which could lead to the tests hanging in certain timeout issues. This fix adjust the kogic so that rather than checking for genesis the code checks that if there is a current header and no previous changes set created a header update is initiated. In practise for non-test related processing this is only true when the genesis block is processed. Technical debt reduction: [align forward and backward changeset processing](ce79fe7) during testing I noticed that there is a difference between the way the txpool subscriber processes FORWARD vs BACKWARD inbound change sets. The FORWARD processing was leading to a potential truncation of the mined tx's. Although this issue goes away when the regression fix above is applied, to avoid future issues I have aligned the FORWARD and BACKWARD inbound processing so they both contain the same logic, they just act on different tx collections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains 2 changes + a series of printer adjustments which where useful in debugging, either to provide additional information or to remove what now seems like excess info or prints.
The 2 functional changes are as follows:
Regression fix:
only start header change for empty changeset is a change to a regression created by removing a check which only added an additional start event for the genesis block. The original change was to fix another issue encountered in running unit tests - which could lead to the tests hanging in certain timeout issues.
This fix adjusts the logic so that rather than checking for genesis the code checks that if there is a current header and no previous changes set created a header update is initiated. In practise for non-test related processing this is only true when the genesis block is processed.
Technical debt reduction:
align forward and backward changeset processing during testing I noticed that there is a difference between the way the txpool subscriber processes FORWARD vs BACKWARD inbound change sets. The FORWARD processing was leading to a potential truncation of the mined tx's.
Although this issue goes away when the regression fix above is applied, to avoid future issues I have aligned the FORWARD and BACKWARD inbound processing so they both contain the same logic, they just act on different tx collections.