Skip to content

qa-tests: add Geth test to the RPC Historic Performance Tests#18895

Merged
mriccobene merged 7 commits into
mainfrom
qa-tests/rpc_perf_historic_with_geth
Feb 5, 2026
Merged

qa-tests: add Geth test to the RPC Historic Performance Tests#18895
mriccobene merged 7 commits into
mainfrom
qa-tests/rpc_perf_historic_with_geth

Conversation

@mriccobene

Copy link
Copy Markdown
Member

No description provided.

@mriccobene mriccobene changed the title qa-tests: add Geth to RPC Historic Performance Tests qa-tests: add Geth test to RPC Historic Performance Tests Jan 30, 2026
@mriccobene mriccobene changed the title qa-tests: add Geth test to RPC Historic Performance Tests qa-tests: add Geth test to the RPC Historic Performance Tests Jan 30, 2026
@mriccobene mriccobene marked this pull request as ready for review February 4, 2026 08:08
Copilot AI review requested due to automatic review settings February 4, 2026 08:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the “QA - RPC Performance Tests” workflow to optionally run Historic RPC performance benchmarks against Geth in addition to Erigon, and refactors the workflow to share setup/config across benchmark runs.

Changes:

  • Add workflow_dispatch input and setup job to control when Geth benchmarks run (scheduled only on Sundays; manual via input).
  • Convert the benchmark job into a matrix over client: [erigon, geth] with client-specific runner selection and DB upload naming.
  • Adjust scheduling time and update artifact naming to include chain/client.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/qa-rpc-performance-tests.yml
Comment thread .github/workflows/qa-rpc-performance-tests.yml
Comment thread .github/workflows/qa-rpc-performance-tests.yml
Comment thread .github/workflows/qa-rpc-performance-tests.yml Outdated
Comment thread .github/workflows/qa-rpc-performance-tests.yml Outdated
Comment thread .github/workflows/qa-rpc-performance-tests.yml
@mriccobene mriccobene merged commit 1fb7ba8 into main Feb 5, 2026
20 checks passed
@mriccobene mriccobene deleted the qa-tests/rpc_perf_historic_with_geth branch February 5, 2026 15:14
mattevans added a commit to ethpandaops/erigone-legacy that referenced this pull request Feb 6, 2026
* upstream/main: (91 commits)
  perf(cl/block_collector): optimize encodeBlock buffer allocation (erigontech#18980)
  db/kv: fix code cache hash key computation (erigontech#18965)
  Fix hive tests 0302 (erigontech#18986)
  perf(execution/types): optimize EIP-7685 request encoding (erigontech#18985)
  refactor: replace interface{} with any for clarity and modernization (erigontech#18978)
  refactor: replace interface{} with any for clarity and modernization (erigontech#18977)
  Rework Dockerhub API call authorization mechanism. (erigontech#18989)
  claude: add erigon-network-ports skill (erigontech#18992)
  PersistentBlockCollector: assert on inserting gap (erigontech#18979)
  qa-tests: add Geth test to the RPC Historic Performance Tests (erigontech#18895)
  a bit less debug logs (erigontech#18974)
  ProcessFrozenBlocks: to support `isDomainAheadOfBlocks` (which we have in `fcu`) (erigontech#18981)
  qa-tests: fix summary in RPC Performance Tests Latest (erigontech#18984)
  handle edge case for genesis block in SeekCommitment (erigontech#18960)
  db/preverified: remove redundant assertSorted in Get (erigontech#18967)
  txnprovider/shutter: fix identity preimage DecodeSSZ error length (erigontech#18938)
  perf(cl/sentinel): use stack allocation for light_client response prefix (erigontech#18961)
  Add debug.SetupSimple, and improve torrent client status info log (erigontech#18953)
  Refactor worker count calculation to remove redundant bounds check (erigontech#18415)
  fix: remove duplicate TxPoolBlobPriceBumpFlag check in setTxPool (erigontech#18472)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants