rpc: fix txpool_content crash: unknown#18111
Merged
Merged
Conversation
AskAlexSharov
approved these changes
Dec 1, 2025
AskAlexSharov
approved these changes
Dec 1, 2025
| slotRlp := txns[i].TxnSlot.Rlp | ||
| slotRlp := rlpValues[i] | ||
| if slotRlp == nil { | ||
| v, err := tx.GetOne(kv.PoolTransaction, txns[i].TxnSlot.IDHash[:]) |
Collaborator
There was a problem hiding this comment.
ok. but then txns[i].TxnSlot.IDHash also need move under lock?
Member
Author
There was a problem hiding this comment.
apparently, TxnSlot.IDHash is written once when TxnSlots are parsed in Fetch before inserting them into the tx pool and never changed later on, even when they get discarded, so TxnSlot.IDHash is immutable
canepat
added a commit
that referenced
this pull request
Dec 1, 2025
Fixes #18076 The new `TestQueryAllWithoutPanicUnknown` tests fails i.e. reproduces systematically the issue (100 out of 100 times) with the existing code.
canepat
added a commit
that referenced
this pull request
Dec 1, 2025
Fixes #18076 The new `TestQueryAllWithoutPanicUnknown` tests fails i.e. reproduces systematically the issue (100 out of 100 times) with the existing code.
AskAlexSharov
pushed a commit
that referenced
this pull request
Dec 2, 2025
AskAlexSharov
pushed a commit
that referenced
this pull request
Dec 2, 2025
marcello33
added a commit
to 0xPolygon/erigon
that referenced
this pull request
Feb 18, 2026
* [r32] Caplin: add get blobs support (fusaka) (erigontech#17840) Cherry pick erigontech#17829 to `release/3.2` Co-authored-by: Giulio rebuffo <giulio.rebuffo@gmail.com> * [3.2] prune: 500ms pruning timeout for stage_exec on ChainTiptar (erigontech#17890) to increase prune timeout 2x as a hotfix for reported prune issue on ethmainnet will create bigger epic today * [3.2] remove `amoy` chain from `sync-from-scratch-test` list (erigontech#17921) * cp Integrity check: compare state progress and block progress (erigontech#18002) issue: erigontech#17911 * [3.2] version (erigontech#18057) * [r3.2] rpc: fix txpool_content crash: unknown (erigontech#18119) Cherry-pick erigontech#18111 * [3.2] Bump max blob size (erigontech#18329) Previous limit was not enough for a 6 blob EIP-4844 transaction with commitments and proofs. The theoretical max size is ~824 KB. * Revert "[3.2] remove `amoy` chain from `sync-from-scratch-test` list (erigontech#17921)" This reverts commit 61d4ffc. * lisovo: CLZ opcode and P256 gas cost changes (#117) * tbdhf: CLZ opcode and P256 gas cost changes * chore: rename to lisovo * feat: flexible base fee on lisovo HF (#118) * chore: add amoy hf block number * fix: lint --------- Co-authored-by: Lucca Martins <lucca_martins30@yahoo.com.br> * chore: bump version * core, execution, polygon: lisovoPro HF and version bump * core: lisovo-lisovoPro instructionset test * core, execution, polygon: lisovoPro HF and version bump (#123) * core, execution, polygon: lisovoPro HF and version bump * core: lisovo-lisovoPro instructionset test * lisovo HF and version bump --------- Co-authored-by: Andrew Ashikhmin <34320705+yperbasis@users.noreply.github.com> Co-authored-by: Giulio rebuffo <giulio.rebuffo@gmail.com> Co-authored-by: Alex Sharov <AskAlexSharov@gmail.com> Co-authored-by: sudeepdino008 <sudeepdino008@gmail.com> Co-authored-by: canepat <16927169+canepat@users.noreply.github.com> Co-authored-by: Shoham Chakraborty <shhmchk@gmail.com> Co-authored-by: Pratik Patil <pratikspatil024@gmail.com> Co-authored-by: Krishang <109511742+kamuikatsurgi@users.noreply.github.com> Co-authored-by: Lucca Martins <lucca_martins30@yahoo.com.br>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18076
The new
TestQueryAllWithoutPanicUnknowntests fails i.e. reproduces systematically the issue (100 out of 100 times) with the existing code.