Skip to content

Caplin: add get blobs support (fusaka)#17829

Merged
Giulio2002 merged 4 commits into
mainfrom
caplin_getBlobs
Nov 10, 2025
Merged

Caplin: add get blobs support (fusaka)#17829
Giulio2002 merged 4 commits into
mainfrom
caplin_getBlobs

Conversation

@Giulio2002

@Giulio2002 Giulio2002 commented Nov 9, 2025

Copy link
Copy Markdown
Contributor

just add getBlobs support really, nothing much, nothing less.

@Giulio2002

Copy link
Copy Markdown
Contributor Author

@copilot lemme ping ya

Copilot AI commented Nov 9, 2025

Copy link
Copy Markdown
Contributor

@Giulio2002 I've opened a new pull request, #17830, to work on those changes. Once the pull request is ready, I'll request review from you.

@Giulio2002

Copy link
Copy Markdown
Contributor Author

ops wrong place

@Giulio2002 Giulio2002 enabled auto-merge (squash) November 9, 2025 23:15
@Giulio2002 Giulio2002 requested a review from Copilot November 9, 2025 23:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for retrieving blob data from the execution layer's transaction pool to optimize blob data availability checks. The main goal is to avoid redundant blob retrieval from the P2P network when blobs are already available in the txpool.

Key changes:

  • Added a new GetBlobs method to the ExecutionEngine interface for querying blobs from the txpool
  • Modified fork choice logic to check txpool for blobs before falling back to P2P retrieval
  • Updated ExecutionClientDirect constructor to accept a txpool client parameter

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
node/eth/backend.go Passes txpool client to ExecutionClientDirect constructor
cl/phase1/execution_client/interface.go Adds GetBlobs method to ExecutionEngine interface
cl/phase1/execution_client/execution_client_direct.go Implements GetBlobs to query txpool for blob data
cl/phase1/execution_client/execution_client_rpc.go Adds stub GetBlobs implementation returning nil
cl/phase1/execution_client/execution_engine_mock.go Auto-regenerated mock with new GetBlobs method
cl/phase1/forkchoice/on_block.go Adds logic to check EL txpool for blobs before P2P retrieval

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread cl/phase1/forkchoice/on_block.go
@Giulio2002 Giulio2002 merged commit b66163f into main Nov 10, 2025
23 of 24 checks passed
@Giulio2002 Giulio2002 deleted the caplin_getBlobs branch November 10, 2025 08:04
mh0lt pushed a commit that referenced this pull request Nov 10, 2025
just add getBlobs support really, nothing much, nothing less.
yperbasis added a commit that referenced this pull request Nov 11, 2025
Cherry pick #17829 to `release/3.2`

Co-authored-by: Giulio rebuffo <giulio.rebuffo@gmail.com>
marcello33 added a commit to 0xPolygon/erigon that referenced this pull request Feb 18, 2026
* [r32] Caplin: add get blobs support (fusaka) (erigontech#17840)

Cherry pick erigontech#17829 to `release/3.2`

Co-authored-by: Giulio rebuffo <giulio.rebuffo@gmail.com>

* [3.2] prune: 500ms pruning timeout for stage_exec on ChainTiptar (erigontech#17890)

to increase prune timeout 2x as a hotfix for reported prune issue on
ethmainnet
will create bigger epic today

* [3.2] remove `amoy` chain from `sync-from-scratch-test` list (erigontech#17921)

* cp Integrity check: compare state progress and block progress (erigontech#18002)

issue: erigontech#17911

* [3.2] version (erigontech#18057)

* [r3.2] rpc: fix txpool_content crash: unknown (erigontech#18119)

Cherry-pick erigontech#18111

* [3.2] Bump max blob size (erigontech#18329)

Previous limit was not enough for a 6 blob EIP-4844 transaction with
commitments and proofs. The theoretical max size is ~824 KB.

* Revert "[3.2] remove `amoy` chain from `sync-from-scratch-test` list (erigontech#17921)"

This reverts commit 61d4ffc.

* lisovo: CLZ opcode and P256 gas cost changes (#117)

* tbdhf: CLZ opcode and P256 gas cost changes

* chore: rename to lisovo

* feat: flexible base fee on lisovo HF (#118)

* chore: add amoy hf block number

* fix: lint

---------

Co-authored-by: Lucca Martins <lucca_martins30@yahoo.com.br>

* chore: bump version

* core, execution, polygon: lisovoPro HF and version bump

* core: lisovo-lisovoPro instructionset test

* core, execution, polygon: lisovoPro HF and version bump (#123)

* core, execution, polygon: lisovoPro HF and version bump

* core: lisovo-lisovoPro instructionset test

* lisovo HF and version bump

---------

Co-authored-by: Andrew Ashikhmin <34320705+yperbasis@users.noreply.github.com>
Co-authored-by: Giulio rebuffo <giulio.rebuffo@gmail.com>
Co-authored-by: Alex Sharov <AskAlexSharov@gmail.com>
Co-authored-by: sudeepdino008 <sudeepdino008@gmail.com>
Co-authored-by: canepat <16927169+canepat@users.noreply.github.com>
Co-authored-by: Shoham Chakraborty <shhmchk@gmail.com>
Co-authored-by: Pratik Patil <pratikspatil024@gmail.com>
Co-authored-by: Krishang <109511742+kamuikatsurgi@users.noreply.github.com>
Co-authored-by: Lucca Martins <lucca_martins30@yahoo.com.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants