Merged
Conversation
Signed-off-by: Shriram Rajagopalan <rshriram@tetrate.io>
Signed-off-by: Shriram Rajagopalan <rshriram@tetrate.io>
Contributor
|
Can you wait to get envoyproxy/envoy#7723? |
Contributor
|
Could you fix the circleci failure? |
Member
Author
|
Sure. I had to fix envoyproxy/envoy#7769 anyway.. if 7723 is going to get in, then we can pull that in as well. |
Signed-off-by: Shriram Rajagopalan <rshriram@tetrate.io>
Member
Author
|
dont merge until 7769 in envoy merges |
dio
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Jul 31, 2019
Description: Fix missing gogo annotation. The file-level `equal_all` annotation was missing in one of the files and failed to compile in go-control-plane. envoyproxy/go-control-plane#201 Risk Level: Low Testing: go-control-plane Docs Changes: N/A Release Notes: N/A Signed-off-by: Shriram Rajagopalan <rshriram@tetrate.io>
mattklein123
pushed a commit
to envoyproxy/data-plane-api
that referenced
this pull request
Jul 31, 2019
Description: Fix missing gogo annotation. The file-level `equal_all` annotation was missing in one of the files and failed to compile in go-control-plane. envoyproxy/go-control-plane#201 Risk Level: Low Testing: go-control-plane Docs Changes: N/A Release Notes: N/A Signed-off-by: Shriram Rajagopalan <rshriram@tetrate.io> Mirrored from https://github.com/envoyproxy/envoy @ bdd6788f1e01787d015eabd9902f4b565e5dea98
Signed-off-by: Shriram Rajagopalan <rshriram@tetrate.io>
Member
Author
|
okay this is ready to go. Can we get this going now as ZhonngXu has agreed to do all the pilot level fixes. we can do another go control plane update when the listener stuff lands later tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shriram Rajagopalan rshriram@tetrate.io