Fix missing annotation in http_uri.proto#7769
Merged
dio merged 1 commit intoenvoyproxy:masterfrom Jul 31, 2019
Merged
Conversation
Signed-off-by: Shriram Rajagopalan <rshriram@tetrate.io>
Member
Author
|
cc @kyessenov / @yangminzhu .. needed to get go-cp to take in the new updated protos without the nullable thing. |
Contributor
|
I thought you are removing gogoproto annotations, not adding them :P |
Member
Author
|
Yeah but you have to be consistent. equal_all missing in one file triggered compilation errors when nullable was removed. equal_all is a top level annotation, like what we hve for java/etc. Not field level thingy like nullable that pollutes struct types. |
htuch
approved these changes
Jul 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Fix missing gogo annotation. The file-level
equal_allannotation was missing in one of the files and failed to compile in go-control-plane.envoyproxy/go-control-plane#201
Risk Level: Low
Testing: go-control-plane
Docs Changes: N/A
Release Notes: N/A
Signed-off-by: Shriram Rajagopalan rshriram@tetrate.io