e2e: update the test for shared rate limits without client selectors#8025
e2e: update the test for shared rate limits without client selectors#8025zirain merged 12 commits intoenvoyproxy:mainfrom
Conversation
…he E2E test for shared rate limits without client selectors Signed-off-by: liuhy <liuhongyu@apache.org>
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR updates the global shared rate limit test data and strengthens the E2E test that verifies gateway-level shared rate limits without client selectors, to reduce flakiness and align with the new 100-requests-per-hour limit.
Changes:
- Increase the gateway-level global shared rate limit (without clientSelectors) from 21 to 100 requests per hour in the test manifest.
- Rewrite the
shared_no_client_selectorssubtest inRateLimitGlobalMergeTestto:- Assert the
X-Ratelimit-Limitheader reports100, 100;w=3600. - Warm up the route until a 200 is observed, then send 99 additional successful requests and verify that the 101st request is rate-limited with HTTP 429.
- Assert the
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
test/e2e/tests/ratelimit.go |
Refines the shared_no_client_selectors E2E subtest to explicitly validate the new 100-requests-per-hour shared limit, including header checking and precise counting of allowed vs. limited requests. |
test/e2e/testdata/ratelimit-global-shared-and-unshared-header-match.yaml |
Updates the gateway-level global shared rate limit rule (no clientSelectors) from 21 to 100 requests per hour to match the revised test logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8025 +/- ##
==========================================
- Coverage 73.80% 73.77% -0.04%
==========================================
Files 237 237
Lines 35753 35753
==========================================
- Hits 26389 26375 -14
- Misses 7508 7520 +12
- Partials 1856 1858 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
all the e2e failed, is there some problem with your changes? |
i will check this later |
|
@zirain hi, i have checked actions clearly and there are failures`s details: |
https://github.com/envoyproxy/gateway/actions/runs/21344302872/job/61429446890?pr=8025 --- FAIL: TestE2E/GRPCExtAuthTimeout/ext_auth_with_timeout_behavior (30.00s) https://github.com/envoyproxy/gateway/actions/runs/21344302872/job/61429446925?pr=8025 https://github.com/envoyproxy/gateway/actions/runs/21344302872/job/61429446932?pr=8025 https://github.com/envoyproxy/gateway/actions/runs/21344302872/job/61429446993?pr=8025 https://github.com/envoyproxy/gateway/actions/runs/21344302872/job/61429446920?pr=8025 |
…quests Signed-off-by: liuhy <liuhongyu@apache.org>
@zirain hi, i have fixed shared_no_client_selectors and the ci is passed; If another issue (ext_auth_with_timeout_behavior) needs to be handled, I will create a new PR to handle it. |
|
|
FYI: ext_auth tests are disabled in main, rebase should worked now. |
ok, thx, i will try this later |
FYI: #8070 |
…nvoyproxy#8025) * feat: increase global shared rate limit in test data to 100, update the E2E test for shared rate limits without client selectors Signed-off-by: liuhy <liuhongyu@apache.org> * test: dynamically check remaining rate limit tokens before sending requests Signed-off-by: liuhy <liuhongyu@apache.org> --------- Signed-off-by: liuhy <liuhongyu@apache.org> Signed-off-by: Sadmi Bouhafs <sadmibouhafs@gmail.com>
What type of PR is this?
increase global shared rate limit in test data to 100, update the E2E test for shared rate limits without client selectors
fix this: https://github.com/envoyproxy/gateway/actions/runs/21241339852/job/61121125255
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Release Notes: Yes/No