Skip to content

fix: re-enable ext-auth timeout test#8070

Merged
rudrakhp merged 4 commits intoenvoyproxy:mainfrom
zirain:e2e/refactor-ext-auth-timeout
Feb 11, 2026
Merged

fix: re-enable ext-auth timeout test#8070
rudrakhp merged 4 commits intoenvoyproxy:mainfrom
zirain:e2e/refactor-ext-auth-timeout

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented Jan 27, 2026

fixes: #8046

@zirain zirain requested a review from a team as a code owner January 27, 2026 03:31
@netlify
Copy link
Copy Markdown

netlify bot commented Jan 27, 2026

Deploy Preview for cerulean-figolla-1f9435 canceled.

Name Link
🔨 Latest commit 490eb1b
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/698c6b7209b58200087fb4cc

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.82%. Comparing base (9df84d5) to head (490eb1b).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8070      +/-   ##
==========================================
- Coverage   73.82%   73.82%   -0.01%     
==========================================
  Files         241      241              
  Lines       36609    36609              
==========================================
- Hits        27027    27025       -2     
- Misses       7677     7678       +1     
- Partials     1905     1906       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zirain zirain marked this pull request as draft January 27, 2026 07:42
@zirain
Copy link
Copy Markdown
Member Author

zirain commented Jan 27, 2026

this shouldn't be part of v1.7, marked it as draft first.

@zirain zirain force-pushed the e2e/refactor-ext-auth-timeout branch 2 times, most recently from cb72718 to 8733beb Compare January 29, 2026 05:58
@zirain zirain marked this pull request as ready for review February 5, 2026 23:52
@zirain zirain changed the title e2e: re-enable ext-auth timeout test fix: re-enable ext-auth timeout test Feb 5, 2026
@zirain zirain force-pushed the e2e/refactor-ext-auth-timeout branch 3 times, most recently from a8d5ac2 to c3fef50 Compare February 11, 2026 01:18
@zirain zirain requested a review from zhaohuabing February 11, 2026 01:18
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain force-pushed the e2e/refactor-ext-auth-timeout branch from c3fef50 to ff28427 Compare February 11, 2026 07:04
@zirain zirain requested a review from zhaohuabing February 11, 2026 07:45
@zirain zirain force-pushed the e2e/refactor-ext-auth-timeout branch 2 times, most recently from 71612fa to ef91e36 Compare February 11, 2026 08:14
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain force-pushed the e2e/refactor-ext-auth-timeout branch from ef91e36 to 81e2430 Compare February 11, 2026 08:26
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Copy link
Copy Markdown
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@zhaohuabing zhaohuabing requested a review from a team February 11, 2026 13:12

# Changes that are expected to cause an incompatibility with previous versions, such as deletions or modifications to existing APIs.
breaking changes: |
The `0s` timeout in SecurityPolicy is now treated as infinite timeout instead of immediate timeout.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds unrelated to the e2e test?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

timeout: 0ms # 0 millisecond - should cause timeout

The e2e use 0ms to cause timeout, which is changed in upstream.

@rudrakhp rudrakhp merged commit 92417ee into envoyproxy:main Feb 11, 2026
36 checks passed
@zirain zirain deleted the e2e/refactor-ext-auth-timeout branch February 11, 2026 15:01
Inode1 pushed a commit to Inode1/gateway that referenced this pull request Feb 23, 2026
* e2e: re-enable ext-auth timeout test

Signed-off-by: zirain <zirain2009@gmail.com>

* release notes

Signed-off-by: zirain <zirain2009@gmail.com>

* lint

Signed-off-by: zirain <zirain2009@gmail.com>

* fix test

Signed-off-by: zirain <zirain2009@gmail.com>

---------

Signed-off-by: zirain <zirain2009@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GRPCExtAuthTimeout failed

3 participants