fix: default httproutes order by creation timestamp or "{namespace}/{name}" combination#6550
Merged
zirain merged 2 commits intoenvoyproxy:mainfrom Jul 18, 2025
Merged
Conversation
arkodg
reviewed
Jul 17, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6550 +/- ##
=======================================
Coverage ? 71.08%
=======================================
Files ? 220
Lines ? 37897
Branches ? 0
=======================================
Hits ? 26940
Misses ? 9385
Partials ? 1572 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zirain
approved these changes
Jul 18, 2025
Signed-off-by: Fayiz Musthafa <fayizk1@gmail.com>
6ce1195 to
79007ae
Compare
arkodg
pushed a commit
to arkodg/gateway
that referenced
this pull request
Jul 25, 2025
* leverages the same logic from envoyproxy#6550 and applies it to other places in the gateway-api layer where gateway api resources were being sorted earlier to make translation order more deterministic when the creation timestamp is the same * also add the sort func to GRPCRoute, TLSRoute, TCPRoute and UDPRoute Signed-off-by: Arko Dasgupta <arko@tetrate.io>
zhaohuabing
pushed a commit
that referenced
this pull request
Jul 28, 2025
) * sort gw api resources based on name if creation timestamp is same * leverages the same logic from #6550 and applies it to other places in the gateway-api layer where gateway api resources were being sorted earlier to make translation order more deterministic when the creation timestamp is the same * also add the sort func to GRPCRoute, TLSRoute, TCPRoute and UDPRoute Signed-off-by: Arko Dasgupta <arko@tetrate.io> * lint Signed-off-by: Arko Dasgupta <arko@tetrate.io> --------- Signed-off-by: Arko Dasgupta <arko@tetrate.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix: default httproutes order by creation timestamp or {namespace}/{name}
Alternative approach to #6433
What this PR does / why we need it:
To ensure consistent HTTP route ordering, this pull request incorporates the route’s “{namespace}/{name}” into the default sorting logic alongside the creation timestamp. It prevents the inconsistent reordering that unrelated updates may trigger (i.e. pod churn, etc.).
Requirements for the GW-API under these circumstances:
Which issue(s) this PR fixes:
Fixes #6140
Release Notes: No