sort gw api resources based on name if creation timestamp is same#6599
Merged
zhaohuabing merged 2 commits intoenvoyproxy:mainfrom Jul 28, 2025
Merged
sort gw api resources based on name if creation timestamp is same#6599zhaohuabing merged 2 commits intoenvoyproxy:mainfrom
zhaohuabing merged 2 commits intoenvoyproxy:mainfrom
Conversation
* leverages the same logic from envoyproxy#6550 and applies it to other places in the gateway-api layer where gateway api resources were being sorted earlier to make translation order more deterministic when the creation timestamp is the same * also add the sort func to GRPCRoute, TLSRoute, TCPRoute and UDPRoute Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6599 +/- ##
==========================================
- Coverage 71.05% 71.01% -0.04%
==========================================
Files 225 225
Lines 38992 39070 +78
==========================================
+ Hits 27705 27747 +42
- Misses 9684 9717 +33
- Partials 1603 1606 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jukie
approved these changes
Jul 27, 2025
zhaohuabing
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
leverages the same logic from fix: default httproutes order by creation timestamp or "{namespace}/{name}" combination #6550 and applies it to other places in the gateway-api layer where gateway api resources were being sorted earlier to make translation order more deterministic when the creation timestamp is the same
also add the sort func to GRPCRoute, TLSRoute, TCPRoute and UDPRoute