feat: Implement enabling HTTP/1.1 trailers#2492
Merged
zirain merged 2 commits intoenvoyproxy:mainfrom Jan 24, 2024
Merged
Conversation
Signed-off-by: Lior Okman <lior.okman@sap.com>
Signed-off-by: Lior Okman <lior.okman@sap.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2492 +/- ##
==========================================
- Coverage 64.69% 64.63% -0.06%
==========================================
Files 115 115
Lines 17472 17511 +39
==========================================
+ Hits 11304 11319 +15
- Misses 5447 5469 +22
- Partials 721 723 +2 ☔ View full report in Codecov by Sentry. |
zirain
reviewed
Jan 24, 2024
Member
zirain
left a comment
There was a problem hiding this comment.
I would like to see a e2e test for new feature.
zirain
approved these changes
Jan 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR implements #2487 .
I recommend that issue #2247 be updated so that if upstream TLS is enabled, then instead of forcing HTTP/1.1 if trailers are enabled by using
HttpProtocolOptions_ExplicitHttpConfigin the cluster setup, ALPN should be allowed to choose the best upstream protocol by usingAutoConfigon the cluster level and the trailers should be enabled in the correct place there.