api: Add support for enabling Trailers in HTTP/1.1#2487
Merged
zhaohuabing merged 2 commits intoenvoyproxy:mainfrom Jan 24, 2024
Merged
api: Add support for enabling Trailers in HTTP/1.1#2487zhaohuabing merged 2 commits intoenvoyproxy:mainfrom
zhaohuabing merged 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Lior Okman <lior.okman@sap.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2487 +/- ##
==========================================
+ Coverage 64.63% 64.68% +0.05%
==========================================
Files 115 115
Lines 17467 17472 +5
==========================================
+ Hits 11290 11302 +12
+ Misses 5454 5448 -6
+ Partials 723 722 -1 ☔ View full report in Codecov by Sentry. |
arkodg
reviewed
Jan 24, 2024
| type HTTP3Settings struct { | ||
| } | ||
|
|
||
| // HTTP1Settings provides HTTP/1 configuration on the listener. |
Contributor
There was a problem hiding this comment.
brought up this API in the community meeting today with @guydc
HTTP1 can become the home for other fields such as
- PreserveCasing
- EnableHTTP1.0
so this approach SGTM
zirain
approved these changes
Jan 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds support in
ClientTrafficPolicyfor enabling HTTP/1 trailers.If enabled, it will translate to the
enable_trailersattribute in Envoy's HTTP1ProtocolOptions configuration.