Add Upstream TLS Support by TasdidurRahman · Pull Request #2247 · envoyproxy/gateway

TasdidurRahman · 2023-11-28T12:16:41Z

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes ##2033

go.mod

zirain · 2023-12-01T13:19:29Z

BTW, did upstream has a test for this? if not, can you add a new e2e test?

TasdidurRahman · 2023-12-01T15:41:53Z

BTW, did upstream has a test for this? if not, can you add a new e2e test?

ok, will add e2e test for upstream tls

internal/gatewayapi/route.go

zhaohuabing

Thanks for working on this! This PR is in a good shape, but there're a few things I'd like to improve:

Error handling
Policy status update
unit and e2e tests

TasdidurRahman · 2023-12-05T05:31:50Z

Thanks for working on this! This PR is in a good shape, but there're a few things I'd like to improve:

Error handling

Policy status update

unit and e2e tests

thanks @zhaohuabing for the review, I am working on it

internal/gatewayapi/route.go

arkodg · 2024-01-04T00:36:59Z

hey @TasdidurRahman, can you address the comments ?

TasdidurRahman · 2024-01-04T09:01:33Z

hey @TasdidurRahman, can you address the comments ?

hello @arkodg , I have checked the comments and working accordingly. thanks!

arkodg · 2024-01-17T19:40:45Z

hey @TasdidurRahman any update on this PR ?
(this feature unblocks many users from adopting envoy gateway)

TasdidurRahman · 2024-01-18T13:18:34Z

hey @TasdidurRahman any update on this PR ? (this feature unblocks many users from adopting envoy gateway)

the status update is working fine. adding the e2e test. will be done by next week
@arkodg

internal/ir/xds.go

internal/xds/translator/translator.go

internal/gatewayapi/route.go

soulxu

nice PR, I'm new to gateway api, but have few questions :)

internal/gatewayapi/route.go

arkodg · 2024-01-23T22:11:01Z

hey @TasdidurRahman ive started working on downstream mTLS #2490 which is very similar to this PR, will try and wrap this up by this week, so this PR can reuse the same components for upstream tls

arkodg · 2024-02-14T01:48:00Z

Sorry for the delay @TasdidurRahman , #2490 has merged, recommend using those helper xds methods for this PR as well, tia

TasdidurRahman · 2024-02-14T05:51:53Z

Sorry for the delay @TasdidurRahman , #2490 has merged, recommend using those helper xds methods for this PR as well, tia

np, will do it asap

zirain · 2024-03-02T09:47:58Z

/retest

Xunzhuo · 2024-03-03T10:08:58Z

/retest

arkodg · 2024-03-03T23:47:04Z

@TasdidurRahman all the conformance tests are failing, can you ptal

TasdidurRahman · 2024-03-04T06:40:49Z

@TasdidurRahman all the conformance tests are failing, can you ptal

hi @arkodg , can you rerun the test? ig it was rbac issue

Signed-off-by: Tasdidur Rahman <tasdidurrahmannahyan@gmail.com>

Signed-off-by: TasdidurRahman <tasdid@appscode.com>

Signed-off-by: Tasdidur Rahman <tasdidurrahmannahyan@gmail.com>

Signed-off-by: TasdidurRahman <tasdid@appscode.com>

Signed-off-by: Tasdidur Rahman <tasdidurrahmannahyan@gmail.com>

zirain · 2024-03-04T13:59:21Z

@TasdidurRahman all the conformance tests are failing, can you ptal

hi @arkodg , can you rerun the test? ig it was rbac issue

you can retrigger ci /retest

zirain · 2024-03-04T13:59:28Z

/retest

Xunzhuo

lgtm, thanks!

zirain reviewed Nov 28, 2023

View reviewed changes

go.mod Outdated Show resolved Hide resolved

TasdidurRahman force-pushed the contribTLS branch from 13f6f5e to d0543af Compare November 29, 2023 08:40

TasdidurRahman marked this pull request as ready for review November 29, 2023 11:13

TasdidurRahman requested a review from a team as a code owner November 29, 2023 11:13

zhaohuabing reviewed Dec 5, 2023

View reviewed changes

internal/gatewayapi/route.go Show resolved Hide resolved

zhaohuabing reviewed Dec 5, 2023

View reviewed changes

internal/gatewayapi/route.go Show resolved Hide resolved

zhaohuabing reviewed Dec 5, 2023

View reviewed changes

internal/gatewayapi/route.go Outdated Show resolved Hide resolved

zhaohuabing reviewed Dec 5, 2023

View reviewed changes

internal/gatewayapi/route.go Outdated Show resolved Hide resolved

Xunzhuo added the road-to-ga label Dec 18, 2023

liorokman mentioned this pull request Jan 16, 2024

Support configuring backend requests to use the same HTTP protocol as the client request #2437

Closed

arkodg requested a review from zhaohuabing January 18, 2024 18:21

arkodg reviewed Jan 22, 2024

View reviewed changes

internal/ir/xds.go Outdated Show resolved Hide resolved

arkodg reviewed Jan 22, 2024

View reviewed changes

internal/xds/translator/translator.go Outdated Show resolved Hide resolved

zhaohuabing reviewed Jan 23, 2024

View reviewed changes

internal/gatewayapi/route.go Outdated Show resolved Hide resolved

soulxu reviewed Jan 23, 2024

View reviewed changes

internal/gatewayapi/route.go Outdated Show resolved Hide resolved

soulxu reviewed Jan 23, 2024

View reviewed changes

internal/gatewayapi/route.go Outdated Show resolved Hide resolved

soulxu reviewed Jan 23, 2024

View reviewed changes

internal/gatewayapi/route.go Show resolved Hide resolved

liorokman mentioned this pull request Jan 24, 2024

feat: Implement enabling HTTP/1.1 trailers #2492

Merged

TasdidurRahman dismissed zirain’s stale review via e41bfcc March 4, 2024 06:39

TasdidurRahman and others added 16 commits March 4, 2024 12:55

add upstream tls support

6baa184

Signed-off-by: Tasdidur Rahman <tasdidurrahmannahyan@gmail.com>

update backendtlspolicy status

81bc18f

Signed-off-by: TasdidurRahman <tasdid@appscode.com>

cleanup

6d1d8fc

Signed-off-by: TasdidurRahman <tasdid@appscode.com>

ignore ca check in secrets

54a87b6

Signed-off-by: Tasdidur Rahman <tasdidurrahmannahyan@gmail.com>

fix status condition

40f103b

Signed-off-by: Tasdidur Rahman <tasdidurrahmannahyan@gmail.com>

update error handling

cce254c

Signed-off-by: Tasdidur Rahman <tasdidurrahmannahyan@gmail.com>

add test for backendtlspolicy

2948b8c

Signed-off-by: Tasdidur Rahman <tasdidurrahmannahyan@gmail.com>

rebase

04c7e13

Signed-off-by: Tasdidur Rahman <tasdidurrahmannahyan@gmail.com>

update test for backendtlspolicy

83adafb

Signed-off-by: Tasdidur Rahman <tasdidurrahmannahyan@gmail.com>

reuse tls structures

3d24ccb

Signed-off-by: Tasdidur Rahman <tasdidurrahmannahyan@gmail.com>

remove mtls

efea3e2

Signed-off-by: Tasdidur Rahman <tasdidurrahmannahyan@gmail.com>

move CA config to destination settings

0bc8074

Signed-off-by: TasdidurRahman <tasdid@appscode.com>

update alias

86a290a

Signed-off-by: TasdidurRahman <tasdid@appscode.com>

add upstream tls support

2039dfe

Signed-off-by: TasdidurRahman <tasdid@appscode.com>

fix linter

460eb24

Signed-off-by: Tasdidur Rahman <tasdidurrahmannahyan@gmail.com>

fix rbac for backendtlspolicy

550db2d

Signed-off-by: Tasdidur Rahman <tasdidurrahmannahyan@gmail.com>

TasdidurRahman force-pushed the contribTLS branch from e41bfcc to 550db2d Compare March 4, 2024 06:56

fix testdata

a3b39f2

Signed-off-by: Tasdidur Rahman <tasdidurrahmannahyan@gmail.com>

TasdidurRahman force-pushed the contribTLS branch from adf1666 to a3b39f2 Compare March 4, 2024 07:32

Xunzhuo approved these changes Mar 4, 2024

View reviewed changes

arkodg approved these changes Mar 4, 2024

View reviewed changes

arkodg merged commit ce1eb54 into envoyproxy:main Mar 4, 2024

arkodg mentioned this pull request Mar 4, 2024

BackendTLSPolicy: Support CACerts in Secrets #2777

Closed

Conversation

TasdidurRahman commented Nov 28, 2023

Uh oh!

Uh oh!

zirain commented Dec 1, 2023

Uh oh!

TasdidurRahman commented Dec 1, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zhaohuabing left a comment

Choose a reason for hiding this comment

Uh oh!

TasdidurRahman commented Dec 5, 2023

Uh oh!

Uh oh!

arkodg commented Jan 4, 2024

Uh oh!

TasdidurRahman commented Jan 4, 2024

Uh oh!

arkodg commented Jan 17, 2024

Uh oh!

TasdidurRahman commented Jan 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

soulxu left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

arkodg commented Jan 23, 2024

Uh oh!

arkodg commented Feb 14, 2024

Uh oh!

TasdidurRahman commented Feb 14, 2024

Uh oh!

zirain commented Mar 2, 2024

Uh oh!

Xunzhuo commented Mar 3, 2024

Uh oh!

arkodg commented Mar 3, 2024

Uh oh!

TasdidurRahman commented Mar 4, 2024

Uh oh!

zirain commented Mar 4, 2024

Uh oh!

zirain commented Mar 4, 2024

Uh oh!

Xunzhuo left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

TasdidurRahman commented Jan 18, 2024 •

edited

Loading

soulxu left a comment •

edited

Loading