-
Notifications
You must be signed in to change notification settings - Fork 715
Enable GatewayWithAttachedRoutes test #1201
Copy link
Copy link
Closed
Labels
area/conformanceGateway API Conformance Related IssuesGateway API Conformance Related Issuesgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed
Milestone
Description
Description:
As part of bumping to v0.6.2 #1153, we had to disable GatewayWithAttachedRoutes which checks for the ListenerConditionAccepted to be set https://github.com/kubernetes-sigs/gateway-api/blob/3e2ea60a2b04f3d4ce380f2520dd6027ea678f7d/conformance/tests/gateway-with-attached-routes.go#L66
We need to ensure we always set this condition here
gateway/internal/gatewayapi/validate.go
Line 151 in a4afb8c
| if len(lConditions) == 0 { |
[optional Relevant Links:]
Any extra documentation required to understand the issue.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area/conformanceGateway API Conformance Related IssuesGateway API Conformance Related Issuesgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed