Skip to content

Enable GatewayWithAttachedRoutes test#1229

Merged
arkodg merged 2 commits intoenvoyproxy:mainfrom
muyuan0:1201
Mar 28, 2023
Merged

Enable GatewayWithAttachedRoutes test#1229
arkodg merged 2 commits intoenvoyproxy:mainfrom
muyuan0:1201

Conversation

@muyuan0
Copy link
Copy Markdown
Contributor

@muyuan0 muyuan0 commented Mar 27, 2023

Fix #1201

Signed-off-by: muyuan0 <127020730+muyuan0@users.noreply.github.com>
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #1229 (7510abe) into main (9036533) will increase coverage by 0.10%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1229      +/-   ##
==========================================
+ Coverage   63.16%   63.27%   +0.10%     
==========================================
  Files          79       79              
  Lines        9831     9833       +2     
==========================================
+ Hits         6210     6222      +12     
+ Misses       3201     3192       -9     
+ Partials      420      419       -1     
Impacted Files Coverage Δ
internal/gatewayapi/validate.go 91.29% <100.00%> (+0.03%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@muyuan0 muyuan0 marked this pull request as ready for review March 27, 2023 13:40
@muyuan0 muyuan0 requested a review from a team as a code owner March 27, 2023 13:40
Signed-off-by: muyuan0 <127020730+muyuan0@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !

@arkodg arkodg merged commit cc16d4e into envoyproxy:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable GatewayWithAttachedRoutes test

4 participants