Merged
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1153 +/- ##
==========================================
+ Coverage 62.92% 62.99% +0.07%
==========================================
Files 79 79
Lines 9677 9737 +60
==========================================
+ Hits 6089 6134 +45
- Misses 3174 3186 +12
- Partials 414 417 +3
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ee90e6e to
cc722ce
Compare
2d9b47b to
b76c8fc
Compare
This was referenced Mar 21, 2023
added 13 commits
March 21, 2023 13:13
Fixes: envoyproxy#1152 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Incorporates check added by kubernetes-sigs/gateway-api#1668 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
added 3 commits
March 21, 2023 13:13
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
kflynn
approved these changes
Mar 21, 2023
Contributor
kflynn
left a comment
There was a problem hiding this comment.
Let's land this already so that we can clean up the PRs that depend on it and get them landed too. 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.6.2Ready, because we cannot guarantee that today, raised Support HTTPRoute ConditionRouteConditionReady#1171 to fix itgateway-apitranslator to ensure we always computeResolvedRefscondition which is checked by the newer conformance testsGatewayObservedGenerationBumptestHTTPRouteObservedGenerationBumptestGatewayWithAttachedRoutestest which should be fixed with Enable GatewayWithAttachedRoutes test #1201Fixes: #1152