Conversation
Bumping to include: - `dns: destroy/reinitialize c-ares channel on ARES_ECONNREFUSED`: envoyproxy/envoy#9899. This should resolve the issues we've been seeing with Envoy Mobile hanging on startup and never properly issuing requests if started in the offline state on iOS - `gzip: add force load factory declaration`: envoyproxy/envoy#9942. This will allow us to use the gzip filter with Envoy Mobile Signed-off-by: Michael Rebello <me@michaelrebello.com>
Member
|
This should not pass the liveliness test for iOS. We need envoyproxy/envoy#9875 to merge in order to not have linking issues at runtime. |
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
junr03
reviewed
Feb 10, 2020
Member
junr03
left a comment
There was a problem hiding this comment.
awesome! Looks good to me. Lets wait for CI to pass, and then 🚢!
junr03
approved these changes
Feb 10, 2020
Contributor
Author
|
1% binary size increase with this Envoy bump. Will be investigated in #447 |
This was referenced Feb 10, 2020
Closed
junr03
added a commit
that referenced
this pull request
Feb 13, 2020
Description: envoyproxy/envoy#9767 introduced the bazel option and #663 brought it into envoy mobile. This PR changes the bazel config for android to turn on the logger by default when building on android. It also updates a couple other stale flags and docs. Risk Level: low Testing: tested locally and saw logs Fixes #34 Signed-off-by: Jose Nino <jnino@lyft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumping to include the following fixes:
dns: destroy/reinitialize c-ares channel on ARES_ECONNREFUSED: dns: destroy/reinitialize c-ares channel on ARES_ECONNREFUSED envoy#9899. This should resolve the issues we've been seeing with Envoy Mobile hanging on startup and never properly issuing requests if started in the offline state on iOS. Fixes dns: stuck if started without connectivity #672, though more improvements to DNS resolution will be investigated in dns: faster recovery after no connectivity #673gzip: add force load factory declaration: gzip: add force load factory declaration envoy#9942. This will allow us to use the gzip filter with Envoy Mobileapi listener: add shutdown method and call during server termination: api listener: add shutdown method and call during server termination envoy#9959. Fixes core: engine termination causes crash due to ordering of ApiListener deletion of active streams #667. Fixes core: crash on runtime load on destruction #674Includes the following PRs to fix iOS liveliness tests as well:
metrics service: force link v2 config: metrics service: force link v2 config envoy#9875config: remove ApiTypeOracle assert: config: remove ApiTypeOracle assert envoy#9973Also contains necessary updates to accommodate this change.
Signed-off-by: Michael Rebello me@michaelrebello.com