Closed
Conversation
added 3 commits
October 9, 2019 13:02
Signed-off-by: Alan Chiu <achiu@lyft.com>
Signed-off-by: Alan Chiu <achiu@lyft.com>
Merged
buildbreaker
pushed a commit
that referenced
this pull request
Oct 17, 2019
gRPC codec for kotlin We are able to hit an Envoy backed gRPC server from `lyft.com` We ran into some issues with testing (debug pull: #495). The first is outgoing ALPN is required for gRPC connections: #502. gRPC doesn't support disabling this option when starting up a service. We'll have to revisit this effort in the future. For now, we are primarily missing #494 for local Envoy library e2e testing Signed-off-by: Alan Chiu <achiu@lyft.com> Description: gRPC codec for kotlin Risk Level: low Testing: unit/end-to-end Docs Changes: n/a Release Notes: n/a [Optional Fixes #Issue] [Optional Deprecated:]
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 28, 2022
gRPC codec for kotlin We are able to hit an Envoy backed gRPC server from `lyft.com` We ran into some issues with testing (debug pull: envoyproxy/envoy-mobile#495). The first is outgoing ALPN is required for gRPC connections: envoyproxy/envoy-mobile#502. gRPC doesn't support disabling this option when starting up a service. We'll have to revisit this effort in the future. For now, we are primarily missing envoyproxy/envoy-mobile#494 for local Envoy library e2e testing Signed-off-by: Alan Chiu <achiu@lyft.com> Description: gRPC codec for kotlin Risk Level: low Testing: unit/end-to-end Docs Changes: n/a Release Notes: n/a [Optional Fixes #Issue] [Optional Deprecated:] Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 29, 2022
gRPC codec for kotlin We are able to hit an Envoy backed gRPC server from `lyft.com` We ran into some issues with testing (debug pull: envoyproxy/envoy-mobile#495). The first is outgoing ALPN is required for gRPC connections: envoyproxy/envoy-mobile#502. gRPC doesn't support disabling this option when starting up a service. We'll have to revisit this effort in the future. For now, we are primarily missing envoyproxy/envoy-mobile#494 for local Envoy library e2e testing Signed-off-by: Alan Chiu <achiu@lyft.com> Description: gRPC codec for kotlin Risk Level: low Testing: unit/end-to-end Docs Changes: n/a Release Notes: n/a [Optional Fixes #Issue] [Optional Deprecated:] Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
debug branch