Skip to content

java: create java lib for local testing#494

Closed
buildbreaker wants to merge 16 commits intomasterfrom
java-create-java-lib-for-local-testing
Closed

java: create java lib for local testing#494
buildbreaker wants to merge 16 commits intomasterfrom
java-create-java-lib-for-local-testing

Conversation

@buildbreaker
Copy link
Copy Markdown

@buildbreaker buildbreaker commented Oct 9, 2019

Create a target for generating a Java library used for unit tests

Signed-off-by: Alan Chiu achiu@lyft.com

Description: java: create java lib for local testing
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
[Optional Fixes #Issue]
[Optional Deprecated:]

@buildbreaker buildbreaker marked this pull request as ready for review October 9, 2019 22:26
@buildbreaker buildbreaker mentioned this pull request Oct 15, 2019
#include "jni_support.h"
#include "main_interface.h"

using namespace std;
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the following error in tests:

library/common/jni_interface.cc:81:5: error: 'memcpy' was not declared in this scope
     memcpy(critical_key, headers.headers[i].key.bytes, headers.headers[i].key.length);
     ^~~~~~

buildbreaker pushed a commit that referenced this pull request Oct 17, 2019
gRPC codec for kotlin

We are able to hit an Envoy backed gRPC server from `lyft.com`

We ran into some issues with testing (debug pull: #495). The first is outgoing ALPN is required for gRPC connections: #502. gRPC doesn't support disabling this option when starting up a service. We'll have to revisit this effort in the future.

For now, we are primarily missing #494 for local Envoy library e2e testing

Signed-off-by: Alan Chiu <achiu@lyft.com>

Description: gRPC codec for kotlin
Risk Level: low
Testing: unit/end-to-end
Docs Changes: n/a
Release Notes: n/a
[Optional Fixes #Issue]
[Optional Deprecated:]
@stale
Copy link
Copy Markdown

stale bot commented Oct 22, 2019

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale label Oct 22, 2019
@goaway goaway added no stalebot and removed stale labels Oct 24, 2019
@buildbreaker
Copy link
Copy Markdown
Author

@goaway thanks :)

@rebello95
Copy link
Copy Markdown
Contributor

Is this something we want to merge?

@junr03
Copy link
Copy Markdown
Member

junr03 commented Jan 22, 2020

@buildbreaker going to close this for now as it has grown stale. Feel free to reopen when we take this back up!

@junr03 junr03 closed this Jan 22, 2020
@buildbreaker buildbreaker deleted the java-create-java-lib-for-local-testing branch January 25, 2020 21:09
@buildbreaker buildbreaker restored the java-create-java-lib-for-local-testing branch May 22, 2020 18:31
@buildbreaker buildbreaker reopened this May 22, 2020
Alan Chiu added 3 commits May 22, 2020 12:04
Signed-off-by: Alan Chiu <achiu@lyft.com>
fix
Signed-off-by: Alan Chiu <achiu@lyft.com>
fix
Signed-off-by: Alan Chiu <achiu@lyft.com>
Alan Chiu added 13 commits May 22, 2020 12:06
Signed-off-by: Alan Chiu <achiu@lyft.com>
Signed-off-by: Alan Chiu <achiu@lyft.com>
Signed-off-by: Alan Chiu <achiu@lyft.com>
Signed-off-by: Alan Chiu <achiu@lyft.com>
Signed-off-by: Alan Chiu <achiu@lyft.com>
fix
Signed-off-by: Alan Chiu <achiu@lyft.com>
Signed-off-by: Alan Chiu <achiu@lyft.com>
Signed-off-by: Alan Chiu <achiu@lyft.com>
Signed-off-by: Alan Chiu <achiu@lyft.com>
Signed-off-by: Alan Chiu <achiu@lyft.com>
Signed-off-by: Alan Chiu <achiu@lyft.com>
fix
Signed-off-by: Alan Chiu <achiu@lyft.com>
Signed-off-by: Alan Chiu <achiu@lyft.com>
@buildbreaker buildbreaker force-pushed the java-create-java-lib-for-local-testing branch from f37ad84 to a1b75d8 Compare May 22, 2020 19:10
@buildbreaker buildbreaker deleted the java-create-java-lib-for-local-testing branch May 29, 2020 23:57
@buildbreaker buildbreaker restored the java-create-java-lib-for-local-testing branch March 30, 2021 22:44
@junr03 junr03 deleted the java-create-java-lib-for-local-testing branch July 20, 2021 22:36
jpsim pushed a commit to envoyproxy/envoy that referenced this pull request Nov 28, 2022
gRPC codec for kotlin

We are able to hit an Envoy backed gRPC server from `lyft.com`

We ran into some issues with testing (debug pull: envoyproxy/envoy-mobile#495). The first is outgoing ALPN is required for gRPC connections: envoyproxy/envoy-mobile#502. gRPC doesn't support disabling this option when starting up a service. We'll have to revisit this effort in the future.

For now, we are primarily missing envoyproxy/envoy-mobile#494 for local Envoy library e2e testing

Signed-off-by: Alan Chiu <achiu@lyft.com>

Description: gRPC codec for kotlin
Risk Level: low
Testing: unit/end-to-end
Docs Changes: n/a
Release Notes: n/a
[Optional Fixes #Issue]
[Optional Deprecated:]

Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit to envoyproxy/envoy that referenced this pull request Nov 29, 2022
gRPC codec for kotlin

We are able to hit an Envoy backed gRPC server from `lyft.com`

We ran into some issues with testing (debug pull: envoyproxy/envoy-mobile#495). The first is outgoing ALPN is required for gRPC connections: envoyproxy/envoy-mobile#502. gRPC doesn't support disabling this option when starting up a service. We'll have to revisit this effort in the future.

For now, we are primarily missing envoyproxy/envoy-mobile#494 for local Envoy library e2e testing

Signed-off-by: Alan Chiu <achiu@lyft.com>

Description: gRPC codec for kotlin
Risk Level: low
Testing: unit/end-to-end
Docs Changes: n/a
Release Notes: n/a
[Optional Fixes #Issue]
[Optional Deprecated:]

Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants