Skip to content

ci: re-enable swift library tests#364

Closed
rebello95 wants to merge 37 commits intomasterfrom
swift-tests
Closed

ci: re-enable swift library tests#364
rebello95 wants to merge 37 commits intomasterfrom
swift-tests

Conversation

@rebello95
Copy link
Copy Markdown
Contributor

@rebello95 rebello95 commented Aug 21, 2019

Introduces a custom test runner for iOS which works around a problem being fixed by bazelbuild/rules_apple#549, where we previously were unable to set a device/OS on which to run tests.

This allows us to re-enable swift library tests on CI.

Replaces #338.

Signed-off-by: Michael Rebello me@michaelrebello.com

Broken by #357.

Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
@rebello95
Copy link
Copy Markdown
Contributor Author

Looks like we're having the same issue here that we were on Azure machines:

2019-08-21 20:09:16,432 Creating a new simulator:
Name: New-iPhone X-12.2
 OS: iOS 12.2
Type: iPhone X
2019-08-21 20:09:16,818 Created new simulator 878B1941-91B0-4504-86E1-81A57328E327.
An error was encountered processing the command (domain=com.apple.CoreSimulator.SimError, code=165):
Invalid device state
2019-08-21 20:09:17,129 Deleting simulator 878B1941-91B0-4504-86E1-81A57328E327 asynchronously.
2019-08-21 20:09:17,134 Done.

standalone is deprecated: https://docs.bazel.build/versions/master/user-manual.html#strategy-options

Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
```
Run ls -lh dist/
 total 565672
-rw-r--r--  1 runner  staff   720B Aug 23 05:49 BUILD
-rw-r--r--  1 runner  staff   272M Aug 23 05:51 Envoy
drwxr-xr-x  3 runner  staff    96B Aug 23 05:51 Headers
drwxr-xr-x  3 runner  staff    96B Aug 23 05:51 Modules
```

```
Analyzing: target //examples/swift/hello_world:app (1 packages loaded, 0 targets configured)
 Analyzing: target //examples/swift/hello_world:app (16 packages loaded, 16 targets configured)
Analyzing: target //examples/swift/hello_world:app (16 packages loaded, 16 targets configured)
Analyzing: target //examples/swift/hello_world:app (29 packages loaded, 199 targets configured)
Analyzing: target //examples/swift/hello_world:app (29 packages loaded, 199 targets configured)
ERROR: /Users/runner/runners/2.157.0/work/envoy-mobile/envoy-mobile/dist/BUILD:18:25: in framework_imports attribute of apple_static_framework_import rule //dist:envoy_mobile_ios: attribute must be non empty
INFO: Call stack for the definition of repository 'com_google_protobuf' which is a http_archive (rule definition at /private/var/tmp/_bazel_runner/1cddc09a5d52e3a104110a34c3ea37cb/external/bazel_tools/tools/build_defs/repo/http.bzl:237:16):
 - /private/var/tmp/_bazel_runner/1cddc09a5d52e3a104110a34c3ea37cb/external/envoy_api/bazel/envoy_http_archive.bzl:18:5
 - /private/var/tmp/_bazel_runner/1cddc09a5d52e3a104110a34c3ea37cb/external/envoy/bazel/repositories.bzl:23:5
 - /private/var/tmp/_bazel_runner/1cddc09a5d52e3a104110a34c3ea37cb/external/envoy/bazel/repositories.bzl:474:5
 - /private/var/tmp/_bazel_runner/1cddc09a5d52e3a104110a34c3ea37cb/external/envoy/bazel/repositories.bzl:148:5
 - /Users/runner/runners/2.157.0/work/envoy-mobile/envoy-mobile/WORKSPACE:51:1
ERROR: Analysis of target '//examples/swift/hello_world:app' failed; build aborted: Analysis of target '//dist:envoy_mobile_ios' failed; build aborted
INFO: Elapsed time: 40.579s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (44 packages loaded, 659 targets configured)
FAILED: Build did NOT complete successfully (44 packages loaded, 659 targets configured)
```

Signed-off-by: Michael Rebello <me@michaelrebello.com>
previous commit worked, but it'd be nice to upload/download to parallelize

Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
@rebello95
Copy link
Copy Markdown
Contributor Author

No luck. Tracking here: #383

@rebello95 rebello95 closed this Aug 23, 2019
@rebello95 rebello95 deleted the swift-tests branch August 23, 2019 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant