Default iOS tests to passed versions#549
Default iOS tests to passed versions#549swiple-rules-gardener merged 3 commits intobazelbuild:masterfrom
Conversation
|
blocked on bazelbuild/bazel#9191 |
|
For others who are interested in this you can use this now as long as you always pass some versions on these flags so it doesn't fall back to the very old defaults, we've been using this for months |
62dc22f to
571a382
Compare
|
@thomasvl I think this should be good to merge now |
|
Hm, telling buildkite to rerun the tests to try and see what the failure was. |
|
The failures definitely appear to be related to this change, but I'm not sure why ATM |
|
Is your branch up to date? Maybe something else has changed, and I think BuildKite might try doing PRs off the branch point? |
|
It is up to date yes |
|
I'm not sure why this change would affect the default simulator version for UI tests since I removed the defaults in bazel itself and the tests aren't specifying a version, but if it did affect that the issue might be that 12.2 (which is what the tests are trying to use) isn't from the |
|
Seeing the failures on other things now also, so it isn't this cl. I'll return to this after figuring out what's up on BuildKite. |
This makes the --ios_simulator_version and --ios_simulator_device flags, affect which devices are used for testing if you don't otherwise provide a device or OS version This reverts commit 1a5bd8e.
edb69d4 to
20e5267
Compare
|
@thomasvl all green with that CI fix! |
|
Running this thru internal testing also. But now that I think about it, shouldn't this also be done to the tvOS ones? Since you made to make a change to bazel for this, would the tvOS ones also need the same work? |
|
So actually right now those aren't exposed to starlark. From reading the code it appears to be because bazel wants to deprecate the individual accesses for https://github.com/bazelbuild/bazel/blob/a330febdddbae5751b6bb0cc0a6a84f451df2304/src/main/java/com/google/devtools/build/lib/skylarkbuildapi/apple/ObjcConfigurationApi.java#L62-L74 instead, which rules_apple doesn't currently consume at all. But yes, in theory we should, but also right now tvOS tests (publicly) are a no-op 😄 https://github.com/bazelbuild/rules_apple/blob/97951dce38d36316e870950eaa0c7a5583353a87/apple/testing/default_runner/tvos_test_runner.template.sh |
|
Oh, didn't even know about those, add another thing on the queue to look at updating too… |
|
I think we could easily change the API for the iOS ones here too and then remove the iOS exposed versions from bazel which would probably be nice |
PiperOrigin-RevId: 277545421
This makes the --ios_simulator_version and --ios_simulator_device flags,
affect which devices are used for testing if you don't otherwise provide
a device or OS version
This reverts commit 1a5bd8e.