Remove defaults from Apple device types and versions#9191
Closed
keith wants to merge 1 commit intobazelbuild:masterfrom
Closed
Remove defaults from Apple device types and versions#9191keith wants to merge 1 commit intobazelbuild:masterfrom
keith wants to merge 1 commit intobazelbuild:masterfrom
Conversation
These defaults are very prone to getting out of date, which makes these fields detrimental to rule implementations. In the case of rules_apple we'd like to make the tests default to these versions, if a version isn't passed as part of the test target, unfortunately we cannot differentiate between the user didn't pass a value, and these old versions. Overall these defaults aren't very helpful because with each Xcode update old versions no longer run on developer machines unless they install the old simulator versions manually.
sergiocampama
approved these changes
Aug 16, 2019
Contributor
|
Sorry for being pedantic, what's the behavior with these |
Member
Author
|
If people are passing this flag now, there is no change, if they aren't passing this flag and running a |
Member
|
Importing. |
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These defaults are very prone to getting out of date, which makes these
fields detrimental to rule implementations. In the case of rules_apple
we'd like to make the tests default to these versions, if a version
isn't passed as part of the test target, unfortunately we cannot
differentiate between the user didn't pass a value, and these old
versions. Overall these defaults aren't very helpful because with each
Xcode update old versions no longer run on developer machines unless
they install the old simulator versions manually.