kotlin: update ResponseHandler interface#357
Merged
buildbreaker merged 6 commits intomasterfrom Aug 21, 2019
Merged
Conversation
added 3 commits
August 20, 2019 17:56
Signed-off-by: Alan Chiu <achiu@lyft.com>
Signed-off-by: Alan Chiu <achiu@lyft.com>
Signed-off-by: Alan Chiu <achiu@lyft.com>
goaway
reviewed
Aug 21, 2019
library/java/src/io/envoyproxy/envoymobile/engine/EnvoyHTTPStream.java
Outdated
Show resolved
Hide resolved
added 3 commits
August 20, 2019 18:13
rebello95
approved these changes
Aug 21, 2019
rebello95
added a commit
that referenced
this pull request
Aug 21, 2019
Broken by #357. Signed-off-by: Michael Rebello <me@michaelrebello.com>
Merged
rebello95
added a commit
that referenced
this pull request
Aug 21, 2019
Broken by #357. Signed-off-by: Michael Rebello <me@michaelrebello.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update ResponseHandler interface and update the java types to be consistent with the objc layer
Signed-off-by: Alan Chiu achiu@lyft.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: kotlin: update ResponseHandler interface
Risk Level: low
Testing: unit
Docs Changes: n/a
Release Notes: n/a
[Optional Fixes #Issue]
[Optional Deprecated:]