Merged
Conversation
added 3 commits
July 9, 2021 15:45
junr03
commented
Jul 9, 2021
| - &dns_refresh_rate 60s | ||
| - &dns_fail_base_interval 2s | ||
| - &dns_fail_max_interval 10s | ||
| - &dns_query_timeout 25s |
Member
Author
There was a problem hiding this comment.
Putting a default so no one is burnt by the upstream 5s default. I am working on a parallel PR to make it configurable.
junr03
commented
Jul 9, 2021
| @@ -36,6 +36,7 @@ const std::string config_header = R"( | |||
| - &dns_refresh_rate 60s | |||
| - &dns_fail_base_interval 2s | |||
Member
Author
There was a problem hiding this comment.
@goaway in slack we discussed 25s timeout + 5s failure refresh rate. The rate as is here starts a 2s and backoffs to 10s. Are we ok with that policy or do you want to reduce max to 5s?
Contributor
There was a problem hiding this comment.
I think that policy is fine for now.
Signed-off-by: Jose Nino <jnino@lyft.com>
rebello95
approved these changes
Jul 12, 2021
Augustyniak
pushed a commit
that referenced
this pull request
Jul 15, 2021
Description: Includes three relevant commits: envoyproxy/envoy#17226 envoyproxy/envoy#17274 envoyproxy/envoy#17207 Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Augustyniak
pushed a commit
that referenced
this pull request
Jul 16, 2021
Description: Includes three relevant commits: envoyproxy/envoy#17226 envoyproxy/envoy#17274 envoyproxy/envoy#17207 Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
junr03
added a commit
that referenced
this pull request
Jul 27, 2021
Description: API for addDnsQueryTimeoutSeconds to configure behavior introduced in #1580 Risk Level: low - optional builder API Testing: updated suite. Docs Changes: added Signed-off-by: Jose Nino <jnino@lyft.com>
Augustyniak
pushed a commit
to Augustyniak/envoy-mobile
that referenced
this pull request
Aug 2, 2021
Description: API for addDnsQueryTimeoutSeconds to configure behavior introduced in envoyproxy#1580 Risk Level: low - optional builder API Testing: updated suite. Docs Changes: added Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes three relevant commits:
envoyproxy/envoy#17226
envoyproxy/envoy#17274
envoyproxy/envoy#17207