filter: add ability to resetIdleTimer#17274
Merged
mattklein123 merged 5 commits intoenvoyproxy:mainfrom Jul 10, 2021
junr03:filter-reset-idle-timeout
Merged
filter: add ability to resetIdleTimer#17274mattklein123 merged 5 commits intoenvoyproxy:mainfrom junr03:filter-reset-idle-timeout
mattklein123 merged 5 commits intoenvoyproxy:mainfrom
junr03:filter-reset-idle-timeout
Conversation
Signed-off-by: Jose Nino <jnino@lyft.com>
Member
Author
|
cc @goaway |
mattklein123
requested changes
Jul 8, 2021
Member
mattklein123
left a comment
There was a problem hiding this comment.
Thanks this LGTM. Can you try to quickly add an integration test? Using simulated time it should be pretty easy to prove that this works with a very small integration test filter. (Basically advance time before decodeData to just before the timeout, reset the idle timer in decode data, and then advance time past the timeout, and make sure the stream is not reset, then advance beyond the timeout and make sure it is reset.)
/wait
Member
Author
|
sg, writing up! |
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
Member
Author
|
@mattklein123 done! |
Member
|
Nice. Looks like CI issue though. /wait |
added 2 commits
July 9, 2021 10:06
Signed-off-by: Jose Nino <jnino@lyft.com>
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
goaway
pushed a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Jul 12, 2021
Description: Includes three relevant commits: envoyproxy/envoy#17226 envoyproxy/envoy#17274 envoyproxy/envoy#17207 Signed-off-by: Jose Nino <jnino@lyft.com>
Augustyniak
pushed a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Jul 15, 2021
Description: Includes three relevant commits: envoyproxy/envoy#17226 envoyproxy/envoy#17274 envoyproxy/envoy#17207 Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Augustyniak
pushed a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Jul 16, 2021
Description: Includes three relevant commits: envoyproxy/envoy#17226 envoyproxy/envoy#17274 envoyproxy/envoy#17207 Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Signed-off-by: Jose Nino <jnino@lyft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: allow filters to reset the stream idle timer.
Risk Level: low
Testing: UT and integration.