not sure if failing tests are flakes - im struggling to get any info when clicking on the "details" link

The python one might be a flake that @crockeo was looking into but the core test likely is unexpected. I just reran both the jobs and am hoping that makes it green

@buildbreaker checking the swift_helloworld test it seems to be failing with:

[2021-05-19 17:15:15.447][31938][critical][main] [external/envoy/source/server/server.cc:113] error initializing configuration '': Original IP detection extension not found: 'envoy.http.original_ip_detection.xff'

this was the reason that i added in the xff extension in the build config.

its not clear to me why this is still failing, where the config is coming from, or why the envoy binary doesnt have the extension added

im guessing that the problem is related to the ip detection extension being listed as required in envoy's all_extensions.bzl but its just a guess

any ideas ?

@phlax sorry I didn't see this sooner - if you're adding an extension, it will need to be registered here:
https://github.com/envoyproxy/envoy-mobile/blob/c8ef0d13643e54141e1bfd5ad4fd9018885a0101/envoy_build_config/extension_registry.cc

This has to do with differences in static initialization order when running as a process vs. running as a statically-linked library.

great, thanks - ill update shortly

@goaway ive tried registering the extension - unfortunately it causes an error - something to do with namespacing and factories

im afraid this is about my limit of c++ knowledge - if you can lmk what else is required i would be happy to add