[WIP/TESTING] extensions: Update config#1475
Closed
phlax wants to merge 2 commits intoenvoyproxy:mainfrom
Closed
Conversation
fa420fc to
6444292
Compare
Member
Author
|
@envoyproxy/envoy-mobile-maintainers would you mind allowing CI on this PR - im trying to check if envoyproxy/envoy#16496 will break anything here (almost certainly yes) and what update is required to unbreak it |
Member
Author
|
cc @htuch |
|
@phlax This is quite strange of a symptom because we do have Actions enabled for you (it's enabled for all PRs) Let me see if I can get a quick workaround for you so you can be unblocked |
Member
Author
|
wierdly - i have just received a load of emails telling me that these jobs have failed - but its still not showing here i have enough info from the failing jobs to update PR i think |
|
@phlax Ok! If that works for you for now, I'll let you continue on |
07fb57f to
9073435
Compare
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
94d37dc to
e78bafc
Compare
Contributor
|
@phlax thank you for doing diligence here! Let me know if I can assist. |
goaway
added a commit
that referenced
this pull request
May 22, 2021
Description: When testing #1475 tests were failing as the envoy submodule was behind envoy main. This PR also: - updates the protobuf patch to make it work with v3.16.0 - adds the `envoy.http.original_ip_detection.xff` extension as tests seemed to indicate it as necessary Risk Level: Low Testing: CI Co-authored-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: Ryan Northey <ryan@synca.io>
Member
|
Re-open if needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: extensions: Update config
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]