build: declare original IP detection factories#16621
Merged
snowp merged 1 commit intoenvoyproxy:mainfrom May 21, 2021
Merged
Conversation
Signed-off-by: Mike Schore <mike.schore@gmail.com>
Contributor
Author
|
cc @phlax |
goaway
added a commit
to phlax/envoy-mobile
that referenced
this pull request
May 21, 2021
Signed-off-by: Mike Schore <mike.schore@gmail.com>
Member
|
cc @rgs1 |
rgs1
approved these changes
May 21, 2021
Member
rgs1
left a comment
There was a problem hiding this comment.
Is this something that can be checked by CI to avoid future factories from missing this? Thanks for the fix.
Contributor
Author
|
@rgs In theory one could probably introduce a dependency between the definitions of |
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Signed-off-by: Mike Schore <mike.schore@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: build: declare original IP detection factories
Risk Level: Low
Testing: Local & CI
Signed-off-by: Mike Schore mike.schore@gmail.com