runtime: Add boolean parsing functionality#8476
Merged
mattklein123 merged 6 commits intoenvoyproxy:masterfrom Oct 4, 2019
Merged
runtime: Add boolean parsing functionality#8476mattklein123 merged 6 commits intoenvoyproxy:masterfrom
mattklein123 merged 6 commits intoenvoyproxy:masterfrom
Conversation
added 3 commits
October 3, 2019 12:02
Signed-off-by: Tony Allen <tallen@lyft.com>
Signed-off-by: Tony Allen <tallen@lyft.com>
Signed-off-by: Tony Allen <tallen@lyft.com>
added 2 commits
October 3, 2019 13:27
Signed-off-by: Tony Allen <tallen@lyft.com>
mattklein123
requested changes
Oct 3, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
Thanks this makes sense, one comment.
/wait
Signed-off-by: Tony Allen <tallen@lyft.com>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
Signed-off-by: Tony Allen <tallen@lyft.com>
nandu-vinodan
pushed a commit
to nandu-vinodan/envoy
that referenced
this pull request
Oct 17, 2019
Signed-off-by: Tony Allen <tallen@lyft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A patch to add the ability to parse boolean feature flags using the canonical JSON encoding for boolean values. This is a direct transfer of the code written in #8360, so that we don't lump two non-trivial changes in a single patch.
Risk Level:
Low. There were some minor changes to
featureEnabledand the deprecated variant to use this instead of the custom function implemented in the runtime implementation.Testing:
Unit tests.
Docs Changes:
API docs modified.