adaptive concurrency: Implement runtime knobs#8360
Merged
mattklein123 merged 66 commits intoenvoyproxy:masterfrom Oct 9, 2019
Merged
adaptive concurrency: Implement runtime knobs#8360mattklein123 merged 66 commits intoenvoyproxy:masterfrom
mattklein123 merged 66 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Tony Allen <tallen@lyft.com>
Signed-off-by: Tony Allen <tallen@lyft.com>
Signed-off-by: Tony Allen <tallen@lyft.com>
Signed-off-by: Tony Allen <tallen@lyft.com>
Signed-off-by: Tony Allen <tallen@lyft.com>
Signed-off-by: Tony Allen <tallen@lyft.com>
Signed-off-by: Tony Allen <tony@allen.gg>
Signed-off-by: Tony Allen <tony@allen.gg>
Signed-off-by: Tony Allen <tony@allen.gg>
Signed-off-by: Tony Allen <tony@allen.gg>
Signed-off-by: Tony Allen <tony@allen.gg>
Signed-off-by: Tony Allen <tallen@lyft.com>
Signed-off-by: Tony Allen <tallen@lyft.com>
Signed-off-by: Tony Allen <tallen@lyft.com>
Signed-off-by: Tony Allen <tallen@lyft.com>
This reverts commit 3bab490. Signed-off-by: Tony Allen <tallen@lyft.com>
This reverts commit 793e9d1. Signed-off-by: Tony Allen <tallen@lyft.com>
Signed-off-by: Tony Allen <tallen@lyft.com>
Adds several runtime variables that can override the adaptive concurrency filter and concurrency controller configuration parameters. Signed-off-by: Tony Allen <tony@allen.gg>
Signed-off-by: Tony Allen <tony@allen.gg>
Member
Author
|
/wait |
mattklein123
requested changes
Oct 6, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
Flushing out a few comments. Generally looks great!
/wait
api/envoy/config/filter/http/adaptive_concurrency/v2alpha/adaptive_concurrency.proto
Outdated
Show resolved
Hide resolved
source/extensions/filters/http/adaptive_concurrency/adaptive_concurrency_filter.h
Outdated
Show resolved
Hide resolved
...ce/extensions/filters/http/adaptive_concurrency/concurrency_controller/gradient_controller.h
Outdated
Show resolved
Hide resolved
...e/extensions/filters/http/adaptive_concurrency/concurrency_controller/gradient_controller.cc
Outdated
Show resolved
Hide resolved
Signed-off-by: Tony Allen <tony@allen.gg>
mattklein123
requested changes
Oct 8, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
Thanks looks great with a few small comments.
/wait
Member
Author
|
/wait |
Signed-off-by: Tony Allen <tony@allen.gg>
mattklein123
requested changes
Oct 9, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
Looks great! A few small comments. Also needs a master merge.
/wait
test/extensions/filters/http/adaptive_concurrency/adaptive_concurrency_filter_test.cc
Outdated
Show resolved
Hide resolved
test/extensions/filters/http/adaptive_concurrency/adaptive_concurrency_filter_test.cc
Outdated
Show resolved
Hide resolved
test/extensions/filters/http/adaptive_concurrency/adaptive_concurrency_filter_test.cc
Outdated
Show resolved
Hide resolved
test/extensions/filters/http/adaptive_concurrency/adaptive_concurrency_filter_test.cc
Outdated
Show resolved
Hide resolved
...ensions/filters/http/adaptive_concurrency/concurrency_controller/gradient_controller_test.cc
Outdated
Show resolved
Hide resolved
Signed-off-by: Tony Allen <tony@allen.gg>
nandu-vinodan
pushed a commit
to nandu-vinodan/envoy
that referenced
this pull request
Oct 17, 2019
Signed-off-by: Tony Allen <tony@allen.gg>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds a runtime-configurable killswitch for the adaptive concurrency filter as well as runtime settings for the gradient controller. The parameters can all be set via the proto config and overridden by the runtime settings.
patch 4/n for #7789