grpc: Move the ifdefs around the instantiation of GoogleRpcContext.#8333
Merged
mattklein123 merged 5 commits intoenvoyproxy:masterfrom Sep 26, 2019
Merged
grpc: Move the ifdefs around the instantiation of GoogleRpcContext.#8333mattklein123 merged 5 commits intoenvoyproxy:masterfrom
mattklein123 merged 5 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Member
mattklein123
left a comment
There was a problem hiding this comment.
LGTM with one question. Thanks for the follow up.
/wait-any
Signed-off-by: Joshua Marantz <jmarantz@google.com>
lizan
reviewed
Sep 24, 2019
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
…nvoyproxy#8333) Signed-off-by: Joshua Marantz <jmarantz@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Follow-up from #8293 to move the ifdefs for Google GRPC Context around the instantiation of the helper class.
Risk Level: low
Testing: //test/...
Docs Changes: n/a
Release Notes: n/a