grpc: Separate out grpc_init into its own class#8293
Merged
jmarantz merged 10 commits intoenvoyproxy:masterfrom Sep 23, 2019
Merged
grpc: Separate out grpc_init into its own class#8293jmarantz merged 10 commits intoenvoyproxy:masterfrom
jmarantz merged 10 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
…re no one calls grpc_init directly. Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
lizan
reviewed
Sep 19, 2019
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
…E macro rather than a static. Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
htuch
suggested changes
Sep 20, 2019
Member
htuch
left a comment
There was a problem hiding this comment.
LGTM modulo minor nits. I wish we didn't need to do this, but the gRPC lib is largely opaque, so not much can be done I think.
Signed-off-by: Joshua Marantz <jmarantz@google.com>
htuch
approved these changes
Sep 23, 2019
mattklein123
requested changes
Sep 23, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
LGTM with small nit if possible. Thank you!
| protected: | ||
| ProcessWide process_wide_; // Process-wide state setup/teardown. | ||
| ProcessWide process_wide_; // Process-wide state setup/teardown (excluding grpc). | ||
| Grpc::GoogleGrpcContext google_grpc_context_; |
Member
There was a problem hiding this comment.
nit: is it possible for this to be stubbed when there is no Google-gRPC support compiled in? It's a little strange that we still have the context, but the actual calls inside it are compiled out?
Contributor
Author
There was a problem hiding this comment.
OK fair enough; can make that change. Do you want to consider merging this in first though and I will commit to cleaning it up in a follow-up, so we can de-flake CI?
mattklein123
approved these changes
Sep 23, 2019
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Sep 24, 2019
* Separate out grpc init to a separate class. Signed-off-by: Joshua Marantz <jmarantz@google.com>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
* Separate out grpc init to a separate class. Signed-off-by: Joshua Marantz <jmarantz@google.com>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
* Separate out grpc init to a separate class. Signed-off-by: Joshua Marantz <jmarantz@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Resolves memory-allocation non-determinism stemming from async activity initiated from grpc_init(). See grpc/grpc#20303 for background.
Risk Level: medium -- changes the way grpc is initialized in tests, but in prod should be the same.
Testing: //test/...
Docs Changes: n/a
Release Notes: n/a
Fixes: #8282