make test/integration:http_subset_lb_integration_test IP version envi…#8288
make test/integration:http_subset_lb_integration_test IP version envi…#8288mattklein123 merged 3 commits intoenvoyproxy:masterfrom
Conversation
…ronment aware. Signed-off-by: Xin Zhuang <stevenzzz@google.com>
Signed-off-by: Xin Zhuang <stevenzzz@google.com>
|
/assign zuercher |
|
Nothing about this test depends on which IP version is used (except that it fails if IPv4 isn't available). Parameterizing it will just make it take twice as long without any benefit. What do you think of just replacing |
|
|
/assign htuch |
|
+1 to @zuercher suggestion. |
…egration_test Signed-off-by: Xin Zhuang <stevenzzz@google.com>
|
alright, PTAL. |
envoyproxy#8288) Signed-off-by: Xin Zhuang <stevenzzz@google.com>
envoyproxy#8288) Signed-off-by: Xin Zhuang <stevenzzz@google.com>
envoyproxy#8288) Signed-off-by: Xin Zhuang <stevenzzz@google.com>
…ronment aware.
Signed-off-by: Xin Zhuang stevenzzz@google.com
Description: fix issue #8284
Risk Level: LOW
Testing: unit test
Docs Changes: N/A
Release Notes: N/A
Fixes 8284