config: handling deprecated enum values#8281
Merged
alyssawilk merged 3 commits intoenvoyproxy:masterfrom Sep 24, 2019
Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Contributor
Author
|
cc @kyessenov |
Contributor
Author
|
No clue what's up with CI but I think this is ready for a first pass |
junr03
previously approved these changes
Sep 19, 2019
Member
junr03
left a comment
There was a problem hiding this comment.
lgtm, thanks for turning this around so fast!
Contributor
Author
|
/azp run envoy-linux |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
zuercher
approved these changes
Sep 23, 2019
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
Handling deprecated and deprecated-default enum values as part of our config checking. Risk Level: Medium Testing: new unit tests Docs Changes: updated runtime docs Release Notes: reverted envoyproxy#8207 Fixes envoyproxy#8253 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handling deprecated and deprecated-default enum values as part of our config checking.
Risk Level: Medium
Testing: new unit tests
Docs Changes: updated runtime docs
Release Notes: reverted #8207
Fixes #8253